public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug tui/31301] New: TUI layout reset with file command @ 2024-01-26 20:19 keiths at redhat dot com 2024-01-27 1:40 ` [Bug tui/31301] " ssbssa at sourceware dot org ` (3 more replies) 0 siblings, 4 replies; 5+ messages in thread From: keiths at redhat dot com @ 2024-01-26 20:19 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31301 Bug ID: 31301 Summary: TUI layout reset with file command Product: gdb Version: 14.1 Status: NEW Severity: normal Priority: P2 Component: tui Assignee: unassigned at sourceware dot org Reporter: keiths at redhat dot com Target Milestone: --- [from a discussion on libera.chat] If gdb is started with TUI asm layout enabled, using the "file" command will reset it back to src layout: $ gdb -q -ex "tui layout asm" <!-- asm window appears with "[ No Assembly Available ]" --> (gdb) file a.out Reading symbols from a.out... <!-- asm is replaced with src window --> Related(?): Defining a "hookpost-file" to force asm layout doesn't work. [One can workaround defining hook-stop or hookpost-run.] Reproduced with gdb 13.2, 14.1, and master. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tui/31301] TUI layout reset with file command 2024-01-26 20:19 [Bug tui/31301] New: TUI layout reset with file command keiths at redhat dot com @ 2024-01-27 1:40 ` ssbssa at sourceware dot org 2024-05-23 6:57 ` vries at gcc dot gnu.org ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: ssbssa at sourceware dot org @ 2024-01-27 1:40 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31301 Hannes Domani <ssbssa at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssbssa at sourceware dot org -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tui/31301] TUI layout reset with file command 2024-01-26 20:19 [Bug tui/31301] New: TUI layout reset with file command keiths at redhat dot com 2024-01-27 1:40 ` [Bug tui/31301] " ssbssa at sourceware dot org @ 2024-05-23 6:57 ` vries at gcc dot gnu.org 2024-05-23 7:01 ` vries at gcc dot gnu.org 2024-05-23 7:48 ` vries at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: vries at gcc dot gnu.org @ 2024-05-23 6:57 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31301 Tom de Vries <vries at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vries at gcc dot gnu.org --- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> --- This demonstrator patch fixes it: ... diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c index 70874e5460a..cb5486cfe34 100644 --- a/gdb/tui/tui-hooks.c +++ b/gdb/tui/tui-hooks.c @@ -137,7 +137,7 @@ tui_refresh_frame_and_register_information () else { /* Make sure that the source window is displayed. */ - tui_add_win_to_layout (SRC_WIN); + //tui_add_win_to_layout (SRC_WIN); struct symtab_and_line sal = get_current_source_symtab_and_line (); tui_update_source_windows_with_line (sal); ... but that regresses: ... FAIL: gdb.tui/list.exp: list -q main FAIL: gdb.tui/list.exp: source is still visible ... -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tui/31301] TUI layout reset with file command 2024-01-26 20:19 [Bug tui/31301] New: TUI layout reset with file command keiths at redhat dot com 2024-01-27 1:40 ` [Bug tui/31301] " ssbssa at sourceware dot org 2024-05-23 6:57 ` vries at gcc dot gnu.org @ 2024-05-23 7:01 ` vries at gcc dot gnu.org 2024-05-23 7:48 ` vries at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: vries at gcc dot gnu.org @ 2024-05-23 7:01 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31301 --- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> --- Regression since commit fc9d2d724fc ("Fix "list" command in the TUI"), present since the gdb 10.1 release. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tui/31301] TUI layout reset with file command 2024-01-26 20:19 [Bug tui/31301] New: TUI layout reset with file command keiths at redhat dot com ` (2 preceding siblings ...) 2024-05-23 7:01 ` vries at gcc dot gnu.org @ 2024-05-23 7:48 ` vries at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: vries at gcc dot gnu.org @ 2024-05-23 7:48 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=31301 --- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> --- Created attachment 15531 --> https://sourceware.org/bugzilla/attachment.cgi?id=15531&action=edit Tentative patch This patch fixes the problem and passes the regression test suite. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-23 7:48 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-01-26 20:19 [Bug tui/31301] New: TUI layout reset with file command keiths at redhat dot com 2024-01-27 1:40 ` [Bug tui/31301] " ssbssa at sourceware dot org 2024-05-23 6:57 ` vries at gcc dot gnu.org 2024-05-23 7:01 ` vries at gcc dot gnu.org 2024-05-23 7:48 ` vries at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).