From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 92D5B3858C2F; Mon,  5 Feb 2024 20:43:34 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 92D5B3858C2F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1707165814;
	bh=Z7o2A4rwwaS6sdZYwGupfTeAGR22Hg8N/iid5fTvNs0=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ERw/2bc7COm+ZBKHwnuppUXgyUDyPL7sMlgq+ZjtLhYdFz2al9ptwEKSzGAL+u0CD
	 ms7xhVnZVMZFNF9z17vWDQmAmqG8yitAso5E7YKTCID0K5RF3i0it73zTHVYuHG5sg
	 xTTdd4pnjHXFIMyRe0xmYgN+LXQ40j6Yo9WJAEIM=
From: "carlosgalvezp at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/31331] Wenum-constexpr-conversion should be fixed, soon
 treated as a hard error
Date: Mon, 05 Feb 2024 20:43:34 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: carlosgalvezp at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-31331-4717-Sns2hNCyES@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-31331-4717@http.sourceware.org/bugzilla/>
References: <bug-31331-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31331

--- Comment #19 from Carlos Galvez <carlosgalvezp at gmail dot com> ---
@Simon Marchi I am not able to reproduce the issue you mention in comment #=
4.
With the following change, the entire codebase compiles just fine, including
the problematic example of auto x =3D ~STEP_OVER_BREAKPOINT.

diff --git a/gdbsupport/enum-flags.h b/gdbsupport/enum-flags.h
index 50780043477..21fb4d29abc 100644
--- a/gdbsupport/enum-flags.h
+++ b/gdbsupport/enum-flags.h
@@ -94,7 +94,7 @@ struct enum_underlying_type
   DIAGNOSTIC_PUSH
   DIAGNOSTIC_IGNORE_ENUM_CONSTEXPR_CONVERSION
   typedef typename
-    integer_for_size<sizeof (T), static_cast<bool>(T (-1) < T (0))>::type
+    std::underlying_type<T>::type
     type;
   DIAGNOSTIC_POP
 };

What change did you apply that led to that failure?

--=20
You are receiving this mail because:
You are on the CC list for the bug.=