From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 42FD6385772D; Mon,  5 Feb 2024 19:29:20 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42FD6385772D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1707161360;
	bh=6VPa98ZT+w3GpAwse2+go2VkCKtsbb7jcEe7tN7FT4o=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=abN6rGkmWU/9TUyKt4sO/ltPhRuqQ5DcbN6fajKi0Vp7AWAVpf1f+gISaeR9Uq1BI
	 ZSRkHI9mVyre4iEW6m7MV2/+ShwDQH+YFoU4k2wHglYTkbC7ssLv8OGIjPgmvV/alZ
	 N+uAp6HbMgRZ/DCBcH6AGmE6TzUsNxjmqn90o8dM=
From: "carlosgalvezp at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/31331] Wenum-constexpr-conversion should be fixed, soon
 treated as a hard error
Date: Mon, 05 Feb 2024 19:29:19 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: carlosgalvezp at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-31331-4717-VwtifLgFct@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-31331-4717@http.sourceware.org/bugzilla/>
References: <bug-31331-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31331

--- Comment #11 from Carlos Galvez <carlosgalvezp at gmail dot com> ---
So I applied this change:

$ git diff gdbsupport/
diff --git a/gdbsupport/enum-flags.h b/gdbsupport/enum-flags.h
index 50780043477..212a51396e8 100644
--- a/gdbsupport/enum-flags.h
+++ b/gdbsupport/enum-flags.h
@@ -94,7 +94,7 @@ struct enum_underlying_type
   DIAGNOSTIC_PUSH
   DIAGNOSTIC_IGNORE_ENUM_CONSTEXPR_CONVERSION
   typedef typename
-    integer_for_size<sizeof (T), static_cast<bool>(T (-1) < T (0))>::type
+    integer_for_size<sizeof (T), std::is_signed<typename
std::underlying_type<T>::type>::value>::type
     type;
   DIAGNOSTIC_POP
 };


And leads to the above-attached diff in testsuite/gdb.sum. I'm not sure wha=
t to
make of it, but it does seem to reduce the number of unexpected failures?

< # of expected passes          104586
< # of unexpected failures      685
---
> # of expected passes		104601
> # of unexpected failures	680
108988c108993
< # of known failures           99
---
> # of known failures		97

--=20
You are receiving this mail because:
You are on the CC list for the bug.=