public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/31351] [gdb/testsuite] UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
Date: Tue, 27 Feb 2024 15:24:07 +0000	[thread overview]
Message-ID: <bug-31351-4717-ghOuhVlZDu@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31351-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31351

--- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=50c6682d74bb1b46ae3e140e107549733c699a44

commit 50c6682d74bb1b46ae3e140e107549733c699a44
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Feb 27 16:24:15 2024 +0100

    [gdb/testsuite] Reset errcnt and warncnt in default_gdb_init

    Say we do:
    ...
    $ make check RUNTESTFLAGS="gdb.dap/ada-nested.exp gdb.dap/pause.exp"
    ...
    and add a perror at the end of pause.exp:
    ...
     dap_shutdown
    +
    +perror "foo"
    ...

    We run into:
    ...
    UNRESOLVED: gdb.dap/ada-nested.exp: compilation prog.adb
    ...

    This happens because the perror increases the errcnt, which is not reset at
    the end of the test-case, and consequently the first pass in the following
    test-case is changed into an unresolved.

    Version 1.6.3 of dejagnu contains a fix which produces an unresolved at the
    end of the test-case, which does reset the errcnt, but this is with version
    1.6.1.

    Furthermore, we reset the errcnt in clean_restart, but the pass is produced
    before, so that doesn't help either.

    Fix this by resetting errcnt and warncnt in default_gdb_init.

    Tested on x86_64-linux.

    Approved-By: Tom Tromey <tom@tromey.com>

    PR testsuite/31351
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31351

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-02-27 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07  8:34 [Bug testsuite/31351] New: " vries at gcc dot gnu.org
2024-02-27  9:07 ` [Bug testsuite/31351] " vries at gcc dot gnu.org
2024-02-27 15:24 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-27 15:25 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31351-4717-ghOuhVlZDu@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).