public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug dap/31354] [gdb/dap] FAIL: gdb.dap/pause.exp: python command failed
Date: Tue, 27 Feb 2024 16:56:41 +0000	[thread overview]
Message-ID: <bug-31354-4717-DEGCoSlVKf@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31354-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31354

--- Comment #4 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a207f6b3a384897be1dab081a0a9a206593029de

commit a207f6b3a384897be1dab081a0a9a206593029de
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Feb 15 13:14:43 2024 -0700

    Rewrite "python" command exception handling

    The "python" command (and the Python implementation of the gdb
    "source" command) does not handle Python exceptions in the same way as
    other gdb-facing Python code.  In particular, exceptions are turned
    into a generic error rather than being routed through
    gdbpy_handle_exception, which takes care of converting to 'quit' as
    appropriate.

    I think this was done this way because PyRun_SimpleFile and friends do
    not propagate the Python exception -- they simply indicate that one
    occurred.

    This patch reimplements these functions to respect the general gdb
    convention here.  As a bonus, some Windows-specific code can be
    removed, as can the _execute_file function.

    The bulk of this change is tweaking the test suite to match the new
    way that exceptions are displayed.  These changes are largely
    uninteresting.  However, it's worth pointing out the py-error.exp
    change.  Here, the failure changes because the test changes the host
    charset to something that isn't supported by Python.  This then
    results in a weird error in the new setup.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31354
    Acked-By: Tom de Vries <tdevries@suse.de>
    Reviewed-By: Eli Zaretskii <eliz@gnu.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-02-27 16:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08  8:41 [Bug dap/31354] New: " vries at gcc dot gnu.org
2024-02-08 12:47 ` [Bug dap/31354] " vries at gcc dot gnu.org
2024-02-08 16:54 ` tromey at sourceware dot org
2024-02-15 18:55 ` tromey at sourceware dot org
2024-02-16 18:38 ` tromey at sourceware dot org
2024-02-27 16:56 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-27 16:56 ` cvs-commit at gcc dot gnu.org
2024-02-27 16:57 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31354-4717-DEGCoSlVKf@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).