[Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset

[Bug symtab/31361] New: .debug_names uses wrong form for DW_IDX_die_offset

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31361

            Bug ID: 31361
           Summary: .debug_names uses wrong form for DW_IDX_die_offset
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

I noticed today that DW_IDX_die_offset is documented
as having a reference form, but right now gdb emits
it as:

                m_abbrev_table.append_unsigned_leb128 (DW_IDX_die_offset);
                m_abbrev_table.append_unsigned_leb128 (DW_FORM_udata);

this should probably be DW_FORM_sec_offset

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31361

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27453


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27453
[Bug 27453] [meta] DWARF 5 support
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31361

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |15.1

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Setting the target milestone here because this code is new
and so we can fix it before it is visible in a release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31361

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31361

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
DW_FORM_ref_addr is better I think.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31361

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2024-February/206505.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31361

--- Comment #4 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=932e5949a9f366d149b1b9093c49225502dee890

commit 932e5949a9f366d149b1b9093c49225502dee890
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Feb 9 17:40:35 2024 -0700

    Use DW_FORM_ref_addr for DIE offset in .debug_names

    Today I realized that while the .debug_names writer uses DW_FORM_udata
    for the DIE offset, DW_FORM_ref_addr would be more appropriate here.
    This patch makes this change.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31361

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31361] .debug_names uses wrong form for DW_IDX_die_offset

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31361

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.