From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 1733A3858414; Tue, 13 Feb 2024 09:44:22 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1733A3858414
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1707817463;
	bh=STZHZaCUiPS67q8YX4lad3sPpdBreDap75oDwxHBM4g=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ir7YvWQZ1L+pwlpRG1+2MezqPgsywCH/vmwjtwhSvHNwUH0LgMmLBaO7wqLIKkIwl
	 lC46jzOzR6qJaMmsp3SNOr7TwhpDoD/UXtyWR2+ei/ejeU5ZyozUDbbs6C4YBxzwl9
	 IxczBk+SNrgPg5lblZViZl0V9xytkHqa/xtBVkf8=
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug dap/31374] [gdb/dap] FAIL: gdb.dap/sources.exp: get source
 success
Date: Tue, 13 Feb 2024 09:44:22 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: dap
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-31374-4717-yseEoK57k9@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-31374-4717@http.sourceware.org/bugzilla/>
References: <bug-31374-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31374

--- Comment #1 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D4dad3c1e1c9e=
789addc0d196cef8e8ea22ddbeda

commit 4dad3c1e1c9e789addc0d196cef8e8ea22ddbeda
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Feb 13 10:44:25 2024 +0100

    [gdb/testsuite] Fix tcl error in gdb.dap/sources.exp

    With test-case gdb.dap/sources.exp, I run into:
    ...
    {"request_seq": 4, "type": "response", "command": "source", \
      "success": false, "message": "notStopped", \
      "seq": 11}FAIL: gdb.dap/sources.exp: get source success
    ERROR: tcl error sourcing gdb.dap/sources.exp.
    ERROR: key "body" not known in dictionary
    ...

    The FAIL has been filed as PR dap/31374.

    The ERROR happens because after the FAIL, dap_check_request_and_response
    returns "", and the test-case doesn't check for that.

    Fix this by checking for $obj !=3D "" in the test-case.

    Tested on x86_64-linux.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=