[Bug ada/31378] New: Ada test suite regression with mold

[Bug ada/31378] New: Ada test suite regression with mold

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31378

            Bug ID: 31378
           Summary: Ada test suite regression with mold
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ada
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

If I set my system linker to be 'mold', I get:

FAIL: gdb.ada/import.exp: print exported_var_ada
FAIL: gdb.ada/import.exp: print imported_var_ada
FAIL: gdb.ada/import.exp: print local_imported_var
FAIL: gdb.ada/import.exp: print pkg.exported_var_ada
FAIL: gdb.ada/import.exp: print pkg.imported_var_ada

These don't happen with ld.bfd or ld.gold.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/31378] Ada test suite regression with mold

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31378

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Created attachment 15367
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15367&action=edit
patch

We've been using this patch internally at AdaCore.
I don't really remember the details but basically
mold decides to make some symbols file-local.
I'm unsure if this patch is really the best way though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/31378] Ada test suite regression with mold

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31378

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/31378] Ada test suite regression with mold

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31378

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2025-January/214778.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/31378] Ada test suite regression with mold

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31378

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ae700d95c66340d7e1cfc6b2d72480caed929eb0

commit ae700d95c66340d7e1cfc6b2d72480caed929eb0
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Jan 13 10:39:50 2025 -0700

    Fix gdb.ada/import.exp when using mold

    We found that the gdb.ada/import.exp test fails when 'mold' is used as
    the linker.  This happens because mold decides to mark most of the
    symbols in the executable as being file-local.  I tend to think this
    choice, while non-traditional, is probably fine.  So, this patch fixes
    the problem by changing the relevant Ada code to look for file-local
    symbols as well.

    Furthermore, there are two overloads of lookup_minimal_symbol_linkage
    that both have a final 'bool' parameter -- but with radically
    different meanings.  This patch somewhat clears up this confusion as
    well.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31378

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/31378] Ada test suite regression with mold

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31378

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |17.1
         Resolution|---                         |FIXED

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.