public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug dap/31380] [gdb/dap] Ensure responses are flushed to client before exiting
Date: Mon, 19 Feb 2024 08:43:26 +0000 [thread overview]
Message-ID: <bug-31380-4717-SDyI6oXg9x@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31380-4717@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=31380
--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #1)
> +dap_check_log_file_re "JSON writer: terminating"
>
> I suspect the issue is that the writer thread notifies
> the queue -- but then the log is written when the thread
> actually stops. However, that means there is a race:
> gdb may stop before the thread exits.
>
> I believe that adding a log just before the final
> call to task_done in the writer, then checking for this
> would work reliably.
I've addressed this by waiting in the DAP main thread for the JSON writer
thread to exit. This ensures that the "JSON writer: terminating" is in the
log.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2024-02-19 8:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 11:23 [Bug dap/31380] New: " vries at gcc dot gnu.org
2024-02-15 18:19 ` [Bug dap/31380] " tromey at sourceware dot org
2024-02-15 18:21 ` tromey at sourceware dot org
2024-02-16 11:46 ` vries at gcc dot gnu.org
2024-02-19 8:25 ` vries at gcc dot gnu.org
2024-02-19 8:43 ` vries at gcc dot gnu.org [this message]
2024-02-21 9:46 ` cvs-commit at gcc dot gnu.org
2024-02-22 10:35 ` cvs-commit at gcc dot gnu.org
2024-02-22 10:40 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-31380-4717-SDyI6oXg9x@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=gdb-prs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).