[Bug dap/31386] [gdb/dap] Race between dap startup and dap log file initialization

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31386

--- Comment #8 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=05bf17f03b890424312163463754de63cee73074

commit 05bf17f03b890424312163463754de63cee73074
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Feb 22 11:35:26 2024 +0100

    [gdb/dap] Fix race between dap startup and dap log file

    In dap_gdb_start we do:
    ...
            append GDBFLAGS " -iex \"set debug dap-log-file $logfile\" -q
-i=dap"
    ...

    While the dap log file setting comes before the dap interpreter setting,
    the order is the other way around:
    - first, the dap interpreter is started
    - second, the -iex commands are executed and the log file is initialized.

    Consequently, there's a race between dap interpreter startup and dap log
file
    initialization.

    This cannot be fixed by using -eiex instead.  Before the interpreter is
    started, the "set debug dap-log-file" command is not yet registered.

    Fix this by postponing the start of the DAP server until GDB has processed
all
    command files.

    Tested on aarch64-linux.

    Approved-By: Tom Tromey <tom@tromey.com>

    PR dap/31386
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31386

-- 
You are receiving this mail because:
You are on the CC list for the bug.