[Bug testsuite/31410] [gdb/testsuite] FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: first argument not expanded

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31410

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[gdb/Linaro CI progression] |[gdb/testsuite] FAIL:
                   |FAIL:                       |gdb.base/startup-with-shell
                   |gdb.base/startup-with-shell |.exp: startup_with_shell =
                   |.exp: startup_with_shell =  |off; run_args =
                   |off; run_args =             |*.unique-extension: first
                   |*.unique-extension: first   |argument not expanded
                   |argument not expanded       |
          Component|external                    |testsuite

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Maxim Kuvyrkov from comment #1)
> Hi Tom,
> 
> Yes, this annoys me as well, but the problem is a bit more complicated.  Our
> CI automatically updates xfails file, which includes both failed test in the
> baseline and flaky tests.
> 
> The problem with this test, is that it consistently fails in our post-commit
> CI jobs, but tends to pass in the pre-commit jobs.  Since we are using
> baseline results from the post-commit CI to compare pre-commit CI results
> against -- we get this "progression".
> 

Hi Maxim,

I see, interesting.

> We have it on our TODO list to fix this problem, but it requires digging
> into the GDB testsuite logic to understand where the different behavior is
> coming from.

Understood.

I managed to find the failure mode:
...
(gdb) PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args
= *.unique-extension: inferior started
print argv[1]
$1 = 0xfffeda96
"/home/tcwg-buildslave/workspace/tcwg_gnu_4/abe/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabihf/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extens"...
(gdb) FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args
= *.unique-extension: first argument not expanded
...
at
https://ci.linaro.org/job/tcwg_gdb_check--master-arm-build/lastSuccessfulBuild/artifact/artifacts/00-sumfiles/gdb.log.xz
.

I'm changing the component from external to testsuite.

I think the fix should be the same as in the commit mentioned in comment 0:
...
diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp
b/gdb/testsuite/gdb.base/startup-with-shell.exp
index d5ec503dceb..670fab6a543 100644
--- a/gdb/testsuite/gdb.base/startup-with-shell.exp
+++ b/gdb/testsuite/gdb.base/startup-with-shell.exp
@@ -66,6 +66,7 @@ with_test_prefix "startup_with_shell = on; run_args =
*.unique-extension" {

 with_test_prefix "startup_with_shell = off; run_args = *.unique-extension" {
     initial_setup_simple "off" "$unique_file_dir/*.unique-extension"
+    gdb_test_no_output "set print characters unlimited"
     gdb_test "print argv\[1\]" "\\\$$decimal = $hex
\"$unique_file_dir/\\\*\.unique-extension\"" \
        "first argument not expanded"
 }
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.