From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 8B987385801C; Wed, 6 Mar 2024 21:25:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B987385801C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1709760302; bh=MIRSDpXqUTeKJ+NaVx653/FfGs/wc0FbXYg7VKIAT8E=; h=From:To:Subject:Date:In-Reply-To:References:From; b=dgBTuZQ4fEs03ZYZ+lPqefbJ51hJUCxWMiWGb9QM7P612U2k6pOcPqJiTcgI/Tvp2 UKe89U7ifKm3DewZi9q60a8cUFS6DVRsDOfWTojMCaAUXswZYXiSfJnFhgl2YNmGN+ QDusUJdGEz5Gcs/0chiYLy2fI2xGOmeMA98zOLL8= From: "amerey at redhat dot com" To: gdb-prs@sourceware.org Subject: [Bug tui/31449] TUI crash with debuginfod support Date: Wed, 06 Mar 2024 21:25:00 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tui X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: amerey at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31449 Aaron Merey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amerey at redhat dot com --- Comment #2 from Aaron Merey --- This is caused by attempting to divide by a width of 0 in tui_inject_newline_into_command_window. The width is 0 because the windows= are not fully initialized during the debuginfod prompt. To fix this we could simply raise the debuginfod prompt at the very beginni= ng of tui_enable_command when debuginfod 'ask' is set. Otherwise a fix might involve more intricate changes to tui's initialization. (In reply to Tom Tromey from comment #1) > I sort of wish the debuginfod 'ask' approach didn't even exist. > It would fix this bug for one thing. Agreed, I'd prefer a simple text notice instead of the y/n prompt. Somethi= ng like, "This GDB will auto-download debuginfo from the following URLs... To disable, use the commmand 'set debuginfod enabled off' or add this command = to .gdbinit." The prompt was originally motivated by debuginfod getting enabled by defaul= t in Fedora. The idea was to give users an additional chance to opt out. I thi= nk now there is generally less of a need for this much notice since debuginfod= has been around for a while and users are more familiar with it. Plus when the .gdb_index downloading feature that's currently under review = [1] gets merged, there will be much less for gdb to download at start up. Since the cost to leaving debuginfod accidentally enabled will be significantly reduced, it should be ok to replace the prompt with a notice IMO. [1] https://sourceware.org/pipermail/gdb-patches/2024-January/205953.html --=20 You are receiving this mail because: You are on the CC list for the bug.=