public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/31483] [gdb/build, postmarketos] error: 'W_EXITCODE' was not declared in this scope
Date: Thu, 14 Mar 2024 20:27:53 +0000	[thread overview]
Message-ID: <bug-31483-4717-tfSsSdCwBP@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31483-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31483

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=97e9c24c38513a69db81fe4c8206785c3a7050af

commit 97e9c24c38513a69db81fe4c8206785c3a7050af
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Mar 14 21:28:44 2024 +0100

    [gdb/build] Fix build on postmarketos

    I tried building gdbserver on postmarketos (which is based on alpine linux,
    which uses musl libc), and ran into:
    ...
    gdbserver/linux-low.cc: In lambda function:
    gdbserver/linux-low.cc:1907:41: error: \
      'W_EXITCODE' was not declared in this scope
     1907 |               mark_lwp_dead (leader_lp, W_EXITCODE (0, 0), true);
          |                                         ^~~~~~~~~~
    ...

    The macro W_EXITCODE is not defined in gdbsupport/gdb_wait.h.

    OTOH, WSETEXIT is defined there, but unused:
    ...
     /* These are not defined in POSIX, but are used by our programs.  */

     #ifndef WSETEXIT
     # ifdef W_EXITCODE
     #define WSETEXIT(w,status) ((w) = W_EXITCODE(status,0))
     # else
     #define WSETEXIT(w,status) ((w) = (0 | ((status) << 8)))
     # endif
     #endif
    ...

    Fix this by dropping the WSETEXIT definition, and instead defining
W_EXITCODE.

    Tested on x86_64-linux, in combination with an "#undef W_EXITCODE" to make
    sure the definition is exercised.

    Approved-By: Tom Tromey <tom@tromey.com>

    PR build/31483
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31483

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-03-14 20:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14  7:53 [Bug build/31483] New: " vries at gcc dot gnu.org
2024-03-14  8:34 ` [Bug build/31483] " vries at gcc dot gnu.org
2024-03-14  8:35 ` vries at gcc dot gnu.org
2024-03-14  9:55 ` vries at gcc dot gnu.org
2024-03-14 20:27 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-14 20:28 ` vries at gcc dot gnu.org
2024-03-14 22:43 ` sam at gentoo dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31483-4717-tfSsSdCwBP@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).