[Bug gdb/31497] gdb internal fatal error while opening a core dump; binary built with '-gsplit-dwarf'

["sungdgdhtryrt at gmail dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31497

--- Comment #2 from Hans <sungdgdhtryrt at gmail dot com> ---
Thank you for your very valuable advice. Your assumption about the
missing read for the str_offset section was correct. Adding a read in
read_dwo_str_index() prevents the crash and gdb is happy.
Although the read will be called twice now in read_dwo_str_index() and
read_str_index().

Thanks again for your help.


diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 4afb026b8ce..a54e783d614 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -17483,6 +17483,12 @@ read_dwo_str_index (const struct die_reader_specs
*reader, ULONGEST str_index)
         so assume the .debug_str_offsets section is DWARF5 as well, and
         parse the header.  FIXME: Parse the header only once.  */
       unsigned int bytes_read = 0;
+
+      // @@@
+      struct objfile *objfile = reader->cu->per_objfile->objfile;
+      reader->dwo_file->sections.str_offsets.read (objfile);
+      // @@@
+
       bfd *abfd = reader->dwo_file->sections.str_offsets.get_bfd_owner ();
       const gdb_byte *p = reader->dwo_file->sections.str_offsets.buffer;

-- 
You are receiving this mail because:
You are on the CC list for the bug.