public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/31502] [gdb/testsuite] FAIL: gdb.server/server-connect.exp: tcp6: connect to gdbserver using tcp6:::1
Date: Wed, 20 Mar 2024 18:31:47 +0000	[thread overview]
Message-ID: <bug-31502-4717-PbTddy5V6u@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31502-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31502

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=886d73049c55fa10447240e4b81c413beba31458

commit 886d73049c55fa10447240e4b81c413beba31458
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Mar 20 19:31:24 2024 +0100

    [gdb/testsuite] Fix gdb.server/server-connect.exp for missing ipv6

    On a system without ipv6 support enabled, when running test-case
    gdb.server/server-connect.exp, it takes about 4 minutes, and I get:
    ...
    builtin_spawn gdbserver --once ::1:2347 server-connect^M
    Can't open socket: Address family not supported by protocol.^M
    Exiting^M
    PASS: gdb.server/server-connect.exp: tcp6: start gdbserver
    target remote tcp6:::1:2347^M
    A program is being debugged already.  Kill it? (y or n) y^M
    could not connect: Address family not supported by protocol.^M
    (gdb) FAIL: gdb.server/server-connect.exp: tcp6: connect to gdbserver using
tcp6:::1
    ...

    Fix this by:
    - recognizing the error message in gdbserver_start, and returning an empty
list
      to signal unsupported, and
    - handling the unsupported response in the test-case.

    This brings testing time down to 2 seconds, and gets me:
    ...
    UNSUPPORTED: gdb.server/server-connect.exp: tcp6: start gdbserver
    UNSUPPORTED: gdb.server/server-connect.exp: tcp6-with-brackets: start
gdbserver
    UNSUPPORTED: gdb.server/server-connect.exp: udp6: start gdbserver
    UNSUPPORTED: gdb.server/server-connect.exp: udp6-with-brackets: start
gdbserver
    ...

    Tested on aarch64-linux.

    Approved-By: Tom Tromey <tom@tromey.com>

    PR testsuite/31502
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31502

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-03-20 18:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-16 15:20 [Bug testsuite/31502] New: " vries at gcc dot gnu.org
2024-03-18  7:47 ` [Bug testsuite/31502] " vries at gcc dot gnu.org
2024-03-19  7:47 ` vries at gcc dot gnu.org
2024-03-20 18:31 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-21  8:03 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31502-4717-PbTddy5V6u@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).