From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 172C43858C36; Mon, 25 Mar 2024 14:28:47 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 172C43858C36
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1711376927;
	bh=255gMdyLpcVN+s4C4okub7tjOCxOSt3Lr6M+UTtRk0w=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Q0RkBuP7XFfBHvZ+Yn+gYtmQT9vWpue1CNCVQnhRB0IoBM7kgMWQsAa2P3h/X8T8G
	 Xc2BrtLds6YdWmxp2yIneR1MFHqpoYOr1ghfKpDr/A/J5Ctki6az2zuIiqNSvRLHIP
	 4Sq8F96NmRDnh8XmSqIvygdSvh1N/kIOl+I0jg90=
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/31514] [gdb/testsuite] FAIL:
 gdb.ada/tagged-lookup.exp: only one CU expanded
Date: Mon, 25 Mar 2024 14:28:46 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-31514-4717-JXXjBitLvx@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-31514-4717@http.sourceware.org/bugzilla/>
References: <bug-31514-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31514

--- Comment #9 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D874f4887f036=
1e953f7098459ae60a5f894d362a

commit 874f4887f0361e953f7098459ae60a5f894d362a
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Mar 25 15:28:35 2024 +0100

    [gdb/testsuite] Fix gdb.ada/tagged-lookup.exp with gcc <=3D 12

    With gcc 13, test-case gdb.ada/tagged-lookup.exp passes for me, but with
gcc
    12, I get:
    ...
    (gdb) set debug symtab-create 1^M
    (gdb) print *the_local_var^M
      ...
    $1 =3D (n =3D> 2)^M
    (gdb) FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded
    ...

    The problem is that this fails:
    ...
        -re -wrap ".* =3D \\\(n =3D> $decimal\\\)" {
            if {$found_pck + $found_pck2 =3D=3D 1} {
                pass $gdb_test_name
            } else {
                fail $gdb_test_name
            }
    ...
    because $found_pck =3D=3D 0 and $found_pck2 =3D=3D 0.

    Indeed, with gcc 13 we have:
    ...
    $ grep "start_subfile: name =3D .*/tagged-lookup/" gdb.log | sed 's%.*/=
%%'
    b~foo.adb
    b~foo.adb
    b~foo.adb
    b~foo.ads
    pck2.adb
    pck2.adb
    pck2.ads
    pck2.adb
    pck2.ads
    ...
    and with gcc 12:
    ...
    $ grep "start_subfile: name =3D .*/tagged-lookup/" gdb.log | sed 's%.*/=
%%'
    b~foo.adb
    b~foo.adb
    b~foo.adb
    b~foo.ads
    ...

    Fix this by checking for "$found_pck + $found_pck2 <=3D 1" instead.

    Tested on x86_64-linux.

    Approved-By: Tom Tromey <tom@tromey.com>

    PR testsuite/31514
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31514

--=20
You are receiving this mail because:
You are on the CC list for the bug.=