From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id CA7593858420; Thu, 28 Mar 2024 11:07:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA7593858420 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1711624063; bh=dZDkANjJJ4XgqHz2eoKaWLdp9+URdDYqu5M1hhoo128=; h=From:To:Subject:Date:In-Reply-To:References:From; b=vJcxyn6VtA3So/vJuTo88aNQJFEjlEChKW8YwPPjBpQYTHjrZxppVkSNeKi3Z2iWo sLkZiXNiCx33JfWL9hlegfEZl9FoznagKF4lscR6/vxwhTQfrwc43YOl7E7V1JlLZO k1J58ffezXOK0ypAUQZXRFkfCwSPrGDfcAXktZi0= From: "pedro at palves dot net" To: gdb-prs@sourceware.org Subject: [Bug tui/31522] TUI misses highlight after run to main Date: Thu, 28 Mar 2024 11:07:43 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tui X-Bugzilla-Version: unknown X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: pedro at palves dot net X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: tromey at sourceware dot org X-Bugzilla-Target-Milestone: 15.1 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31522 --- Comment #8 from Pedro Alves --- Thanks! Indeed, I played a bit with that patch, and the centering seems to work just like it did before, in all the use cases I threw at it. Tromey's change is also needed for the highlight. The old code did: - if (deprecated_safe_get_selected_frame ()) - tui_show_frame_info (deprecated_safe_get_selected_frame ()); - else - tui_display_main (); and I wondered whether we need that tui_display_main call, but I couldn't s= pot a behavior difference without it. I tried enabling the TUI before starting= the program, with and without using "list foo" to move the current source posit= ion elsewhere. IMO, it would be nice if we centered in more cases, like after "frame", for example, or before running the program and you enable the TUI (TUI shows ma= in), but those are not regressions AFAICT. --=20 You are receiving this mail because: You are on the CC list for the bug.=