From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 6A5973858D28; Thu, 28 Mar 2024 14:50:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A5973858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1711637411; bh=i9DlamgIMu8KZKt02G6G/1LtcK75ZejR0yarPIL63f8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=qkNkEyCsR5d3rEAuUssge9CAJhnySH2G05Z1hfmWwT+KU4qawy292HX47dyJ7zCPn 3tokVpXPOH75vPUUKE8bVPQ5KzWmis4QcugImbg8z8mFhb0A/cch6TU1H31t+73Yh7 3SDmCMN1oT6Ls09UE53LKuMO1FwVrsx1H4Q8IFOk= From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tui/31522] TUI misses highlight after run to main Date: Thu, 28 Mar 2024 14:50:10 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tui X-Bugzilla-Version: unknown X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: tromey at sourceware dot org X-Bugzilla-Target-Milestone: 15.1 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31522 Tom de Vries changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #12 from Tom de Vries --- (In reply to Pedro Alves from comment #8) > Thanks! Indeed, I played a bit with that patch, and the centering seems = to > work just like it did before, in all the use cases I threw at it. Tromey= 's > change is also needed for the highlight. >=20 Thanks for trying it out (maybe consider adding a tested-by tag to the submitted patch?). > The old code did: >=20 > - if (deprecated_safe_get_selected_frame ()) > - tui_show_frame_info (deprecated_safe_get_selected_frame ()); > - else > - tui_display_main (); >=20 > and I wondered whether we need that tui_display_main call, but I couldn't > spot a behavior difference without it. I tried enabling the TUI before > starting the program, with and without using "list foo" to move the curre= nt > source position elsewhere. >=20 Ok, understood. > IMO, it would be nice if we centered in more cases, like after "frame", f= or > example, or before running the program and you enable the TUI (TUI shows > main), but those are not regressions AFAICT. Agreed. I played a bit with 'gdb -q a.out -tui' vs 'gdb -q -a.out -ex "tui enable"', where there's also a difference in behaviour. Anyway, since this is a regression fix, I went with this minimal fix, and a= dded a comment at the fix that we could try to improve the fix. --=20 You are receiving this mail because: You are on the CC list for the bug.=