public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/31524] Can't start program in Lazarus/fpc with activated debugging
Date: Thu, 28 Mar 2024 22:31:29 +0000	[thread overview]
Message-ID: <bug-31524-4717-p7GH4EEzsq@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31524-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31524

--- Comment #14 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=edada1692cc4558138756eea99532d83b7b894e0

commit edada1692cc4558138756eea99532d83b7b894e0
Author: Tom Tromey <tom@tromey.com>
Date:   Wed Mar 27 10:34:46 2024 -0600

    Make pascal_language::print_type handle varstring==nullptr

    PR gdb/31524 points out a crash when pascal_language::print_type is
    called with varstring==nullptr.  This crash is a regression arising
    from the printf/pager rewrite -- that indirectly removed a NULL check
    from gdb's "puts".

    This patch instead fixes the problem by adding a check to print_type.
    Passing nullptr here seems to be expected in other places (e.g., there
    is a call to type_print like this in expprint.c), and other
    implementations of this method (or related helpers) explicitly check
    for NULL.

    I didn't write a test case for this because it seemed like overkill
    for a Pascal bug that only occurs with -i=mi.  However, if you want
    one, let me know and I will do it.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31524
    Approved-By: John Baldwin <jhb@FreeBSD.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-03-28 22:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21 20:12 [Bug gdb/31524] New: " reinhard.buchholz at arcor dot de
2024-03-22 16:43 ` [Bug gdb/31524] " tromey at sourceware dot org
2024-03-22 19:28 ` reinhard.buchholz at arcor dot de
2024-03-24 21:17 ` tromey at sourceware dot org
2024-03-25 19:48 ` reinhard.buchholz at arcor dot de
2024-03-25 20:05 ` reinhard.buchholz at arcor dot de
2024-03-25 20:19 ` reinhard.buchholz at arcor dot de
2024-03-25 22:41 ` tromey at sourceware dot org
2024-03-26 13:29 ` reinhard.buchholz at arcor dot de
2024-03-27  1:19 ` tromey at sourceware dot org
2024-03-27  3:40 ` tromey at sourceware dot org
2024-03-27 12:51 ` reinhard.buchholz at arcor dot de
2024-03-27 13:43 ` tromey at sourceware dot org
2024-03-27 16:42 ` tromey at sourceware dot org
2024-03-28 22:31 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-28 22:32 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31524-4717-p7GH4EEzsq@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).