[Bug gdb/31528] [gdb, kernel.yama.ptrace_scope=1] FAIL: gdb.base/attach-deleted-exec.exp: attach to process with deleted executable

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31528

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #1)
> Regardless, it seems that using readlink in linux_proc_pid_to_exec_file may
> be a problem in itself, see:
> - https://bugzilla.suse.com/show_bug.cgi?id=1216352 
> - https://bugzilla.kernel.org/show_bug.cgi?id=211593
> so maybe this needs fixing first.

Which would be fixed by:
...
diff --git a/gdb/nat/linux-procfs.c b/gdb/nat/linux-procfs.c
index b17e3120792..2f8a3b961f7 100644
--- a/gdb/nat/linux-procfs.c
+++ b/gdb/nat/linux-procfs.c
@@ -342,20 +342,7 @@ const char *
 linux_proc_pid_to_exec_file (int pid)
 {
   static char buf[PATH_MAX];
-  char name[PATH_MAX];
-  ssize_t len;
-
-  xsnprintf (name, PATH_MAX, "/proc/%d/exe", pid);
-  len = readlink (name, buf, PATH_MAX - 1);
-  if (len <= 0)
-    strcpy (buf, name);
-  else
-    buf[len] = '\0';
-
-  /* Use /proc/PID/exe if the actual file can't be read, but /proc/PID/exe
-     can be.  */
-  if (access (buf, R_OK) != 0 && access (name, R_OK) == 0)
-    strcpy (buf, name);
+  xsnprintf (buf, PATH_MAX, "/proc/%d/exe", pid);

   return buf;
 }
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.