[Bug testsuite/31566] [gdb/testsuite] is_aarch32_target contains dead code

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31566

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> (In reply to Tom de Vries from comment #1)
> > I'll try to run this in an armhf container on an aarch64-linux system.
> 
> Turns out that one identifies as armv8l-unknown-linux-gnueabihf.
> 
> Which means that is_aarch32_target returns true because istarget "arm*-*-*"
> matches.

So, is_aarch32_target could be simplified to:
...
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index d48ea37c0cc..46f8e36ef4d 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3647,21 +3647,8 @@ proc is_x86_64_m64_target {} {
 # Return 1 if this target is an arm or aarch32 on aarch64.

 gdb_caching_proc is_aarch32_target {} {
-    if { [istarget "arm*-*-*"] } {
-       return 1
-    }
-
-    if { ![istarget "aarch64*-*-*"] } {
-       return 0
-    }
-
-    set list {}
-    foreach reg \
-       {r0 r1 r2 r3} {
-           lappend list "\tmov $reg, $reg"
-       }
-
-    return [gdb_can_simple_compile aarch32 [join $list \n]]
+    # Aarch32 on aarch64 is classified as armv8l.
+    return [istarget "arm*-*-*"]
 }

 # Return 1 if this target is an aarch64, either lp64 or ilp32.
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.