public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/31592] [gdb/testsuite] gdb.dwarf2/dw2-epilogue-begin.exp drops epilogue_begin entry
Date: Wed, 17 Apr 2024 10:54:48 +0000	[thread overview]
Message-ID: <bug-31592-4717-kNYWPNYiuU@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31592-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31592

--- Comment #4 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d52ba54add0d2500403db63c09878e3f3cde8449

commit d52ba54add0d2500403db63c09878e3f3cde8449
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Apr 17 12:55:00 2024 +0200

    [gdb/testsuite] Require address update for DW_LNE_end_sequence

    With test-case gdb.dwarf2/dw2-epilogue-begin.exp, we have an end_sequence
    entry with the same address as the line entry before it:
    ...
    File name                    Line number    Starting address    View   
Stmt

    dw2-epilogue-begin.c                  44            0x4101e8              
x
    dw2-epilogue-begin.c                  47            0x4101ec              
x
    dw2-epilogue-begin.c                   -            0x4101ec
    ...
    and consequently the line entry is removed by gdb:
    ...
    INDEX  LINE   REL-ADDRESS        UNREL-ADDRESS      IS-STMT PRO EPI
    0      20     0x00000000004101a8 0x00000000004101a8 Y       Y   Y
    1      27     0x00000000004101b0 0x00000000004101b0 Y
    2      32     0x00000000004101b8 0x00000000004101b8 Y       Y
    3      34     0x00000000004101c0 0x00000000004101c0 Y           Y
    4      35     0x00000000004101c8 0x00000000004101c8 Y
    5      40     0x00000000004101d4 0x00000000004101d4 Y       Y
    6      44     0x00000000004101e8 0x00000000004101e8 Y
    7      END    0x00000000004101ec 0x00000000004101ec Y
    ...

    This is a common mistake in dwarf assembly test-cases.

    Fix this by:
    - requiring an address update for each DW_LNE_end_sequence, and
    - fixing the test-cases where that triggers an error.

    I also encountered the error in test-case gdb.dwarf2/dw2-bad-elf.exp, and
in
    this case I worked around it using "DW_LNS_advance_pc 0".

    Tested on aarch64-linux.

    PR testsuite/31592
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31592

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-04-17 10:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02  6:37 [Bug testsuite/31592] New: " vries at gcc dot gnu.org
2024-04-02  6:38 ` [Bug testsuite/31592] " vries at gcc dot gnu.org
2024-04-02  7:22 ` vries at gcc dot gnu.org
2024-04-04 15:20 ` vries at gcc dot gnu.org
2024-04-04 19:17 ` blarsen at redhat dot com
2024-04-17 10:54 ` cvs-commit at gcc dot gnu.org [this message]
2024-04-17 10:55 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31592-4717-kNYWPNYiuU@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).