[Bug testsuite/31647] New: [gdb/testsuite, old dejagnu] ERROR: invalid command name "gdb_find_gnatmake"

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31647

            Bug ID: 31647
           Summary: [gdb/testsuite, old dejagnu] ERROR: invalid command
                    name "gdb_find_gnatmake"
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

On SLE-11, with a gdb-13.2-based package, I ran into:
...
Running /usr/src/packages/BUILD/gdb-13.2/gdb/testsuite/gdb.ada/mi_prot.exp ...
UNRESOLVED: gdb.ada/mi_prot.exp: testcase aborted due to invalid command name:
gdb_find_gnatmake
ERROR: tcl error sourcing
/usr/src/packages/BUILD/gdb-13.2/gdb/testsuite/gdb.ada/mi_prot.exp.
ERROR: invalid command name "gdb_find_gnatmake"
    while executing
"::gdb_tcl_unknown gdb_find_gnatmake"
    ("uplevel" body line 1)
    invoked from within
"uplevel 1 ::gdb_tcl_unknown $args"
    (procedure "::unknown" line 5)
    invoked from within
"gdb_find_gnatmake"
    (procedure "gnatmake_version_at_least" line 2)
    invoked from within
"gnatmake_version_at_least 8"
    invoked from within
"if { ![gnatmake_version_at_least 8] } {
    return -1
}"
...

The problem is that gdb_find_gnatmake is a backup for find_gnatmake:
...
if {[info procs find_gnatmake] == ""} {
    rename gdb_find_gnatmake find_gnatmake
    set use_gdb_compile(ada) 1
    gdb_note [join [list $note_prefix "Ada" $note_suffix] ""]
}
...
so gnatmake_version_at_least should use find_gnatmake instead.

We normally don't run into this because dejagnu is recent enough to include a
find_gnatmake, so gdb_find_gnatmake is kept.

With SLE-11, an old dejagnu is used, find_gnatmake is not found so
gdb_find_gnatmake is renamed to find_gnatmake, and we run into the error.

It's confusing that we're using the gdb_ prefix here, it seems something
legitimate to use.

Maybe we should use future_ or gdb_future_ prefix instead to make this more
clear.

Also, we could do:
...
 if {[info procs find_gnatmake] == ""} {
     rename gdb_find_gnatmake find_gnatmake
     set use_gdb_compile(ada) 1
     gdb_note [join [list $note_prefix "Ada" $note_suffix] ""]
 } else {
     rename gdb_find_gnatmake ""
 }
...
to prevent it being used by accident with a newer dejagnu.

-- 
You are receiving this mail because:
You are on the CC list for the bug.