From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 034E23849ACB; Fri, 19 Apr 2024 14:06:02 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 034E23849ACB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1713535563;
	bh=LD4T7v6D7rnYr0U/5LNXB5HfEybWzGJ2qd/KhWO2UAw=;
	h=From:To:Subject:Date:From;
	b=x49TlmAVnN4koDBy2irMGK4+pzJkMgKbrDMSWo7hN1hMFqi6abzHTdzU6VC5sqFyP
	 8BAKuVrtd9g0fa1+w19P3beSRhhaOFWkIrlux+UgAcVs5qWgAjooFX8BSs1e7HR2el
	 Fixvpi6Ouvwtp6bxeEUWHyqBRxcLOfFOrbuFx8Mk=
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/31656] New: [gdb/testsuite] Check gdb_spawn result
Date: Fri, 19 Apr 2024 14:06:01 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-31656-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D31656

            Bug ID: 31656
           Summary: [gdb/testsuite] Check gdb_spawn result
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

I noticed ( https://sourceware.org/pipermail/gdb-patches/2024-April/208304.=
html
) that gdb_spawn is used without checking the result in test-case
gdb.base/sigwinch-notty.exp.

I tried to find some more instances, and got:
...
$ find gdb/testsuite/ -type f | egrep -v ChangeLog | xargs egrep '^[
\t]*gdb_spawn.*[ \t]*$'=20
gdb/testsuite/gdb.base/early-init-file.exp:    gdb_spawn
gdb/testsuite/gdb.base/early-init-file.exp:    gdb_spawn
gdb/testsuite/gdb.base/early-init-file.exp:    gdb_spawn
gdb/testsuite/gdb.base/warning.exp:gdb_spawn_with_cmdline_opts \
gdb/testsuite/gdb.base/sigwinch-notty.exp:    gdb_spawn
gdb/testsuite/gdb.base/attach.exp:    gdb_spawn_attach_cmdline $testpid
gdb/testsuite/gdb.base/libsegfault.exp:    gdb_spawn_with_ld_preload
$libsegfault ""
gdb/testsuite/gdb.base/libsegfault.exp:    gdb_spawn_with_ld_preload
$libsegfault "-q"
gdb/testsuite/gdb.base/readnever.exp:    gdb_spawn
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.=