public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/31705] gdb.base/watchpoint-running.exp fails on arm
Date: Mon, 03 Jun 2024 20:29:29 +0000	[thread overview]
Message-ID: <bug-31705-4717-RNp2Nbi9GD@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31705-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31705

--- Comment #14 from Tom de Vries <vries at gcc dot gnu.org> ---
Copied this approach from aarch64-linux-nat.c:
...
diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
index 50c24ecfcd2..f24e3b45ffb 100644
--- a/gdb/arm-linux-nat.c
+++ b/gdb/arm-linux-nat.c
@@ -92,6 +92,12 @@ class arm_linux_nat_target final : public linux_nat_target

   bool watchpoint_addr_within_range (CORE_ADDR, CORE_ADDR, int) override;

+  /* Override the GNU/Linux inferior startup hook.  */
+  void post_startup_inferior (ptid_t) override;
+
+  /* Override the GNU/Linux post attach hook.  */
+  void post_attach (int pid) override;
+
   const struct target_desc *read_description () override;

   /* Override linux_nat_target low methods.  */
@@ -108,6 +114,8 @@ class arm_linux_nat_target final : public linux_nat_target

 static arm_linux_nat_target the_arm_linux_nat_target;

+static const struct arm_linux_hwbp_cap *arm_linux_get_hwbp_cap (void);
+
 /* Get the whole floating point state of the process and store it
    into regcache.  */

@@ -527,6 +535,24 @@ ps_get_thread_area (struct ps_prochandle *ph,
   return PS_OK;
 }

+/* Implement the virtual inf_ptrace_target::post_startup_inferior method.  */
+
+void
+arm_linux_nat_target::post_startup_inferior (ptid_t ptid)
+{
+  arm_linux_get_hwbp_cap ();
+  linux_nat_target::post_startup_inferior (ptid);
+}
+
+/* Implement the "post_attach" target_ops method.  */
+
+void
+arm_linux_nat_target::post_attach (int pid)
+{
+  arm_linux_get_hwbp_cap ();
+  linux_nat_target::post_attach (pid);
+}
+
 const struct target_desc *
 arm_linux_nat_target::read_description ()
 {
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-06-03 20:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 13:19 [Bug testsuite/31705] New: New tests from g:c223d3738832011ced54e8415fa218934aebd0e4 fail " clyon at gcc dot gnu.org
2024-05-06 13:21 ` [Bug testsuite/31705] " clyon at gcc dot gnu.org
2024-05-07 10:30 ` pedro at palves dot net
2024-05-07 10:47 ` [Bug testsuite/31705] gdb.base/watchpoint-running.exp fails " pedro at palves dot net
2024-05-07 10:52 ` pedro at palves dot net
2024-05-07 10:57 ` luis.machado at arm dot com
2024-05-07 11:24 ` pedro at palves dot net
2024-05-07 11:33 ` luis.machado at arm dot com
2024-06-03 14:00 ` vries at gcc dot gnu.org
2024-06-03 14:29 ` vries at gcc dot gnu.org
2024-06-03 15:00 ` luis.machado at arm dot com
2024-06-03 15:02 ` vries at gcc dot gnu.org
2024-06-03 17:11 ` pedro at palves dot net
2024-06-03 17:44 ` luis.machado at arm dot com
2024-06-03 17:57 ` pedro at palves dot net
2024-06-03 20:29 ` vries at gcc dot gnu.org [this message]
2024-06-03 20:48 ` pedro at palves dot net
2024-06-04 12:06 ` vries at gcc dot gnu.org
2024-06-05  6:52 ` [Bug tdep/31705] " vries at gcc dot gnu.org
2024-06-07  6:39 ` vries at gcc dot gnu.org
2024-06-07  6:52 ` vries at gcc dot gnu.org
2024-06-21 13:13 ` cvs-commit at gcc dot gnu.org
2024-06-21 14:45 ` cvs-commit at gcc dot gnu.org
2024-06-21 14:47 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31705-4717-RNp2Nbi9GD@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).