[Bug gdb/31751] New: re-enable background DWARF reading

[Bug gdb/31751] New: re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

            Bug ID: 31751
           Summary: re-enable background DWARF reading
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

Background DWARF reading (see bug #29942) caused a number
of races.  (I'll change the known ones to block this bug.)

I think we should disable background reading for gdb 15,
then fix the bugs and try to re-enable it for a later release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31715


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=31715
[Bug 31715] race condition in cooked_index_shard::finalize
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31713


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=31713
[Bug 31713] race conditions in target simulation
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29286


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29286
[Bug 29286] SUMMARY: ThreadSanitizer: data race gdb/dwarf2/read.c:4100 in
dw_expand_symtabs_matching_file_matcher
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29366


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29366
[Bug 29366] [meta] New DWARF indexer meta bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31626


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=31626
[Bug 31626] [gdb/symtab] data races in gdb.rust/dwindex.exp
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31264


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=31264
[Bug 31264] [gdb] ThreadSanitizer: data race format.c:132 in bfd_preserve_save
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30837


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=30837
[Bug 30837] [gdb/symtab, index-cache] data race on current_inferior_
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31262


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=31262
[Bug 31262] [gdb] ThreadSanitizer: data raceindex-cache.c:76 in
index_cache::enable()
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31260


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=31260
[Bug 31260] [gdb] ThreadSanitizer: data race /usr/include/c++/13/optional:286
in std::_Optional_payload_base<std::unique_ptr<dwz_file,
std::default_delete<dwz_file> > >::_M_destroy()
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2024-May/209267.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31716


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=31716
[Bug 31716] race condition in libiberty/concat.c
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

--- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b013bd16630fb243d6fa0ee5d4c4eae77f6e5176

commit b013bd16630fb243d6fa0ee5d4c4eae77f6e5176
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri May 17 08:55:46 2024 -0600

    Default dwarf_synchronous to true

    Unfortunately the background DWARF reading series introduced a number
    of races, as repored by thread sanitizer.  This patch changes gdb to
    disable this feature for the time being -- in particular for the gdb
    15 release.

    I've filed a bug and linked all the known races to it.  Once those are
    fixed we can re-enable this feature by default.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31751

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
That patch disabled the feature, but we should leave
this bug open for re-enabling the feature and eventually
backing out that patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751
Bug 31751 depends on bug 29286, which changed state.

Bug 29286 Summary: SUMMARY: ThreadSanitizer: data race gdb/dwarf2/read.c:4100 in dw_expand_symtabs_matching_file_matcher
https://sourceware.org/bugzilla/show_bug.cgi?id=29286

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751
Bug 31751 depends on bug 31715, which changed state.

Bug 31715 Summary: race condition in cooked_index_shard::finalize
https://sourceware.org/bugzilla/show_bug.cgi?id=31715

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751
Bug 31751 depends on bug 31716, which changed state.

Bug 31716 Summary: race condition in libiberty/concat.c
https://sourceware.org/bugzilla/show_bug.cgi?id=31716

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751
Bug 31751 depends on bug 31626, which changed state.

Bug 31626 Summary: [gdb/symtab] data races in gdb.rust/dwindex.exp
https://sourceware.org/bugzilla/show_bug.cgi?id=31626

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751
Bug 31751 depends on bug 31713, which changed state.

Bug 31713 Summary: race conditions in target simulation
https://sourceware.org/bugzilla/show_bug.cgi?id=31713

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

--- Comment #4 from Sam James <sam at gentoo dot org> ---
Any chance of flipping it back to false on master and maybe even depending on
how that goes, getting it into 16?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

--- Comment #5 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f77f3d6d9cef650cf1c3aaf51d91eb9af9cd026d

commit f77f3d6d9cef650cf1c3aaf51d91eb9af9cd026d
Author: Tom Tromey <tom@tromey.com>
Date:   Thu Dec 12 16:21:30 2024 -0700

    Re-enable background reading

    All the reported races have been fixed, so this patch re-enabled
    background DWARF reading.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31751
    Tested-By: Tom de Vries <tdevries@suse.de>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/31751] re-enable background DWARF reading

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31751

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |17.1

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.