public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug python/31845] [gdb/python, arm] FAIL: gdb.python/py-disasm.exp: global_disassembler=ShowInfoRepr: disassemble test
Date: Wed, 05 Jun 2024 09:44:39 +0000	[thread overview]
Message-ID: <bug-31845-4717-VpuT3aGsAl@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31845-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31845

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> FTR, remaining failure:
> ...
> (gdb) PASS: gdb.python/py-disasm.exp: memory source api: disassemble test
> python analyzing_disassembler.find_replacement_candidate()^M
> no nop was found^M
> (gdb) FAIL: gdb.python/py-disasm.exp: memory source api: python
> analyzing_disassembler.find_replacement_candidate()
> ...


Fixed by:
...
index c09eae811ee..2741fdb6c19 100644
--- a/gdb/testsuite/gdb.python/py-disasm.py
+++ b/gdb/testsuite/gdb.python/py-disasm.py
@@ -46,7 +46,7 @@ def check_building_disassemble_result():


 def is_nop(s):
-    return s == "nop" or s == "nop\t0"
+    return s == "nop" or s == "nop\t0" or s == "nop\t{0}"


 # Remove all currently registered disassemblers.
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2024-06-05  9:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  9:41 [Bug python/31845] New: " vries at gcc dot gnu.org
2024-06-05  9:44 ` vries at gcc dot gnu.org [this message]
2024-06-07  6:37 ` [Bug python/31845] " vries at gcc dot gnu.org
2024-06-10 15:52 ` cvs-commit at gcc dot gnu.org
2024-06-10 15:53 ` cvs-commit at gcc dot gnu.org
2024-06-10 15:53 ` vries at gcc dot gnu.org
2024-06-14 14:08 ` vries at gcc dot gnu.org
2024-06-14 14:12 ` vries at gcc dot gnu.org
2024-06-20 13:53 ` cvs-commit at gcc dot gnu.org
2024-06-20 13:53 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31845-4717-VpuT3aGsAl@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).