[Bug python/31845] New: [gdb/python, arm] FAIL: gdb.python/py-disasm.exp: global_disassembler=ShowInfoRepr: disassemble test

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31845

            Bug ID: 31845
           Summary: [gdb/python, arm] FAIL: gdb.python/py-disasm.exp:
                    global_disassembler=ShowInfoRepr: disassemble test
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

I ran test-case gdb.python/py-disasm.exp on arm-linux, getting 26 unexpected
failures.

The first fail I ran into was:
...
disassemble test^M
Dump of assembler code for function test:^M
   0x004004d8 <+0>:     push    {r11}           @ (str r11, [sp, #-4]!)^M
   0x004004dc <+4>:     add     r11, sp, #0^M
   0x004004e0 <+8>:     nop     {0}^M
=> 0x004004e4 <+12>:    nop     {0}^M
   0x004004e8 <+16>:    nop     {0}^M
   0x004004ec <+20>:    mov     r3, #0^M
   0x004004f0 <+24>:    mov     r0, r3^M
   0x004004f4 <+28>:    add     sp, r11, #0^M
   0x004004f8 <+32>:    pop     {r11}           @ (ldr r11, [sp], #4)^M
   0x004004fc <+36>:    bx      lr^M
End of assembler dump.^M
(gdb) FAIL: gdb.python/py-disasm.exp: global_disassembler=: disassemble test
...

Easily fixed by:
...
diff --git a/gdb/testsuite/gdb.python/py-disasm.exp
b/gdb/testsuite/gdb.python/py-disasm.exp
index 7c6f972a7e7..5d7d9221169 100644
--- a/gdb/testsuite/gdb.python/py-disasm.exp
+++ b/gdb/testsuite/gdb.python/py-disasm.exp
@@ -65,7 +65,7 @@ proc py_remove_all_disassemblers {} {
 #
 # Each different disassembler tests some different feature of the
 # Python disassembler API.
-set nop "(nop|nop\t0)"
+set nop "(nop|nop\t0|[string_to_regexp nop\t{0}])"
 set unknown_error_pattern "unknown disassembler error \\(error = -1\\)"
 set addr_pattern "\r\n=> ${curr_pc_pattern} <\[^>\]+>:\\s+"
 set base_pattern "${addr_pattern}${nop}"
...
which brings down the unexpected failures to 21.

New first failure is:
...
disassemble test^M
Dump of assembler code for function test:^M
   0x004004d8 <+0>:     push    {r11}           @ (str r11, [sp, #-4]!)^M
   0x004004dc <+4>:     add     r11, sp, #0^M
   0x004004e0 <+8>:     nop     {0}^M
=> 0x004004e4 <+12>:    Python Exception <class 'ValueError'>: Buffer returned
from read_memory is sized 0 instead of the expected 4^M
^M
unknown disassembler error (error = -1)^M
(gdb) FAIL: gdb.python/py-disasm.exp: global_disassembler=ShowInfoRepr:
disassemble test
...

Fixed by:
...
diff --git a/gdb/python/py-disasm.c b/gdb/python/py-disasm.c
index 2d8ce44a065..0c11c2112b2 100644
--- a/gdb/python/py-disasm.c
+++ b/gdb/python/py-disasm.c
@@ -855,7 +882,7 @@ gdbpy_disassembler::read_memory_func (bfd_vma memaddr,
gdb_byte *buff,
      overridden by the user.  */
   gdbpy_ref<> result_obj (PyObject_CallMethod ((PyObject *) obj,
                                               "read_memory",
-                                              "KL", len, offset));
+                                              "IL", len, offset));

   /* Handle any exceptions.  */
   if (result_obj == nullptr)
...
which brings down the unexpected failures to 1.

FTR, remaining failure:
...
(gdb) PASS: gdb.python/py-disasm.exp: memory source api: disassemble test
python analyzing_disassembler.find_replacement_candidate()^M
no nop was found^M
(gdb) FAIL: gdb.python/py-disasm.exp: memory source api: python
analyzing_disassembler.find_replacement_candidate()
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.