[Bug dap/32029] New: 'cannot unpack non-iterable gdb.Value object' on variables request

[Bug dap/32029] New: 'cannot unpack non-iterable gdb.Value object' on variables request

[letoram at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

            Bug ID: 32029
           Summary: 'cannot unpack non-iterable gdb.Value object' on
                    variables request
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: dap
          Assignee: unassigned at sourceware dot org
          Reporter: letoram at gmail dot com
  Target Milestone: ---

Created attachment 15649
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15649&action=edit
gdb dap log

Sending a request for scope variables (e.g. {"type": "request", "command":
"variables", "seq": 8, "arguments": {"variablesReference": 1}) results in a
success=false response with the following python error:

"cannot unpack non-iterable gdb.Value object".

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/32029] 'cannot unpack non-iterable gdb.Value object' on variables request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Thanks for the report.

From the log it looks like this is failing:

READ: <<<{"type": "request", "command": "variables", "seq": 10, "arguments":
{"variablesReference": 3}}>>>

(since I see a response to request 9)

This scope is:

{"variablesReference": 3, "name": "Globals", "presentationHint": "globals",
"expensive": false, "namedVariables": 1, "source": {"name": "test.c", "path":
"/home/void/test.c"}}

... is it possible to get test.c?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/32029] 'cannot unpack non-iterable gdb.Value object' on variables request

[letoram at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

--- Comment #2 from Björn Ståhl <letoram at gmail dot com> ---
Created attachment 15654
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15654&action=edit
test-case

here's the test case used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/32029] 'cannot unpack non-iterable gdb.Value object' on variables request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-08-15
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
I was able to reproduce.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/32029] 'cannot unpack non-iterable gdb.Value object' on variables request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2024-August/211083.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/32029] 'cannot unpack non-iterable gdb.Value object' on variables request

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

--- Comment #5 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=807f697b176d6c635643118202f36e572872007f

commit 807f697b176d6c635643118202f36e572872007f
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Aug 15 12:06:31 2024 -0600

    Fix DAP failure when fetching global variables

    The relatively new "globals" scope code in DAP has a fairly obvious
    bug -- the fetch_one_child method should return a tuple with two
    elements, but instead just returns the variable's value.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32029
    Reviewed-By: Tom de Vries <tdevries@suse.de>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/32029] 'cannot unpack non-iterable gdb.Value object' on variables request

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |16.1
         Resolution|---                         |FIXED

--- Comment #6 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.
This code doesn't appear on the gdb-15 branch, so no need to backport.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/32029] 'cannot unpack non-iterable gdb.Value object' on variables request

[letoram at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

--- Comment #7 from Björn Ståhl <letoram at gmail dot com> ---
(In reply to Tom Tromey from comment #6)
> Fixed.
> This code doesn't appear on the gdb-15 branch, so no need to backport.

Tested, confirmed it works for the case presented. If I walk the thread stack
and request the variables from the 'globals' scope I get the same error though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug dap/32029] 'cannot unpack non-iterable gdb.Value object' on variables request

[letoram at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=32029

--- Comment #8 from Björn Ståhl <letoram at gmail dot com> ---
(In reply to Björn Ståhl from comment #7)
> (In reply to Tom Tromey from comment #6)
> > Fixed.
> > This code doesn't appear on the gdb-15 branch, so no need to backport.
> 
> Tested, confirmed it works for the case presented. If I walk the thread
> stack and request the variables from the 'globals' scope I get the same
> error though.

please disregard the previous comments, I didn't reference the proper build
when running the test. It works as intended now. Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.