[Bug breakpoints/32434] New: s390: Build failure GNU gdb (GDB) 16.0.50.20241209-git

[Bug breakpoints/32434] New: s390: Build failure GNU gdb (GDB) 16.0.50.20241209-git

[phi.debian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=32434

            Bug ID: 32434
           Summary: s390: Build failure GNU gdb (GDB) 16.0.50.20241209-git
           Product: gdb
           Version: HEAD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: breakpoints
          Assignee: unassigned at sourceware dot org
          Reporter: phi.debian at gmail dot com
  Target Milestone: ---

s390 
Ubuntu 22.04.5 LTS
GNU gdb (GDB) 16.0.50.20241209-git

build gives

-----------------------------------------------------------
_nat_target::remove_watchpoint(CORE_ADDR, int, target_hw_bp_type,
expression*)’:
../../gdb/s390-linux-nat.c:875:11: error: ‘unordered_remove’ was not declared
in this scope
  875 |           unordered_remove (state->watch_areas, ix);
      |           ^~~~~~~~~~~~~~~~
../../gdb/s390-linux-nat.c: In member function ‘virtual int
s390_linux_nat_target::remove_hw_breakpoint(gdbarch*, bp_target_info*)’:
../../gdb/s390-linux-nat.c:928:11: error: ‘unordered_remove’ was not declared
in this scope
  928 |           unordered_remove (state->break_areas, ix);
      |           ^~~~~~~~~~~~~~~~

-----------------------------------------------------------

Adding line in s390-linux-nat.c seems to cure
47a48,49
> #include "gdbsupport/gdb_vecs.h"
> 

Dunno if this is the right thing to do though.
Cheers,
Phi

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/32434] s390: Build failure GNU gdb (GDB) 16.0.50.20241209-git

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32434

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-12-09
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
See also this fix:
https://inbox.sourceware.org/gdb-patches/20241207004547.246474-1-mark@klomp.org/T/#u

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/32434] s390: Build failure GNU gdb (GDB) 16.0.50.20241209-git

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32434

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
commit fea53b8bb575871eaf258f5c3a407daf2d61e797
Author: Mark Wielaard <mark@klomp.org>
Date:   Sat Dec 7 01:37:53 2024 +0100

    Include gdbsupport/gdb_vecs.h in gdb/s390-linux-nat.c

    Commit c8889b913175 ("gdb, gdbserver, gdbsupport: remove some unused
    gdb_vecs.h includes") removed gdbsupport/gdb_vecs.h from various
    header files. This caused an compile issue for gdb/s390-linux-nat.c

    ../../binutils-gdb/gdb/s390-linux-nat.c: In member function ‘virtual int
s390_linux_nat_target::remove_watchpoint(CORE_ADDR, int, target_hw_bp_type,
expression*)’:
    ../../binutils-gdb/gdb/s390-linux-nat.c:875:11: error: ‘unordered_remove’
was not declared in this scope
      875 |           unordered_remove (state->watch_areas, ix);
          |           ^~~~~~~~~~~~~~~~
    ../../binutils-gdb/gdb/s390-linux-nat.c: In member function ‘virtual int
s390_linux_nat_target::remove_hw_breakpoint(gdbarch*, bp_target_info*)’:
    ../../binutils-gdb/gdb/s390-linux-nat.c:928:11: error: ‘unordered_remove’
was not declared in this scope
      928 |           unordered_remove (state->break_areas, ix);
          |           ^~~~~~~~~~~~~~~~

    Fix this by including gdbsupport/gdb_vecs.h in gdb/s390-linux-nat.c.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/32434] s390: Build failure GNU gdb (GDB) 16.0.50.20241209-git

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=32434

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vries at gcc dot gnu.org
   Target Milestone|---                         |16.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.