From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 13EB53858C5E; Wed, 5 Apr 2023 15:27:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13EB53858C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680708477; bh=0M+S9gsLL1n/ZAr+6n83VHuqEe/x5FysldIabC3hMQI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=kRAfsNO3LsjcJpl4RHq+JoGMGZ0dqeEKTU45q2w2Fw7BkWLOpq+sJTDFucjv5K2T4 WqwqQgOonGQMnvUd++PtupWipbI9DWTPXNnVGRKUpWAkJtVx+LXnIoiLNcp5a4K0FJ BD87p9E6CqawNbnaelQ6iSyO9m0YpQCCmDhRFxuk= From: "tromey at sourceware dot org" To: gdb-prs@sourceware.org Subject: [Bug gdb/8390] Move #include "nm.h" from "defs.h" to the *.c files that need it Date: Wed, 05 Apr 2023 15:27:56 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Version: unknown X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: tromey at sourceware dot org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: WONTFIX X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D8390 Tom Tromey changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |tromey at sourceware dot o= rg Status|ASSIGNED |RESOLVED --- Comment #1 from Tom Tromey --- I tend to think this isn't worth doing. nm.h is small and very rarely changes. Including it everywhere isn't a big cost, whereas being more careful with it might cause issues sometimes, if a macro isn't defined in some spot. It may be more worthwhile to try to remove nm.h entirely instead. --=20 You are receiving this mail because: You are on the CC list for the bug.=