public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug remote/9053] remote_xfer_partial(): packet size probe fails when LENGTH and OFFSET are zero [target: avr]
[not found] <bug-9053-4717@http.sourceware.org/bugzilla/>
@ 2014-08-09 0:56 ` cvs-commit at gcc dot gnu.org
2014-08-09 0:58 ` qiyao at gcc dot gnu.org
2014-08-09 1:01 ` qiyao at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2014-08-09 0:56 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=9053
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via dcd2e6ef22c3453b9322ad4b46fb7cc05810b7ee (commit)
from 20c6f1e176f4139ed1e76d4256e70149e38c0820 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dcd2e6ef22c3453b9322ad4b46fb7cc05810b7ee
commit dcd2e6ef22c3453b9322ad4b46fb7cc05810b7ee
Author: Yao Qi <yao@codesourcery.com>
Date: Fri Aug 8 13:45:23 2014 +0800
Fix PR remote/9053: remove dead code on query packet size
The code becomes dead as GDB evolves. In 2003, Andrew Cagney post patch
https://sourceware.org/ml/gdb-patches/2003-10/msg00511.html to add target
read/write partial methods. They support query buffer size when both
OFFSET and LEN is zero, and it was used in avr-tdep.c and kod.c. Then,
Daniel added target_read_object_alloc and avr-tdep.c switches to use that
in patch https://sourceware.org/ml/gdb-patches/2006-07/msg00009.html
From then on, GDB on longer queries the buffer size, so the code
returning packet size in remote_xfer_partial became dead.
PR 17060 is duplicated of PR 9053, so I mention the latter in the
ChangeLog entry. Rebuild GDB with this patch. OK to apply?
I'll mark PR 17060 as duplicated once the patch is applied.
gdb:
2014-08-09 Yao Qi <yao@codesourcery.com>
PR remote/9053
* remote.c (remote_xfer_partial): Remove dead code.
-----------------------------------------------------------------------
Summary of changes:
gdb/ChangeLog | 5 +++++
gdb/remote.c | 4 ----
2 files changed, 5 insertions(+), 4 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug remote/9053] remote_xfer_partial(): packet size probe fails when LENGTH and OFFSET are zero [target: avr]
[not found] <bug-9053-4717@http.sourceware.org/bugzilla/>
2014-08-09 0:56 ` [Bug remote/9053] remote_xfer_partial(): packet size probe fails when LENGTH and OFFSET are zero [target: avr] cvs-commit at gcc dot gnu.org
@ 2014-08-09 0:58 ` qiyao at gcc dot gnu.org
2014-08-09 1:01 ` qiyao at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: qiyao at gcc dot gnu.org @ 2014-08-09 0:58 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=9053
Yao Qi <qiyao at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at redhat dot com
--- Comment #4 from Yao Qi <qiyao at gcc dot gnu.org> ---
*** Bug 17060 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug remote/9053] remote_xfer_partial(): packet size probe fails when LENGTH and OFFSET are zero [target: avr]
[not found] <bug-9053-4717@http.sourceware.org/bugzilla/>
2014-08-09 0:56 ` [Bug remote/9053] remote_xfer_partial(): packet size probe fails when LENGTH and OFFSET are zero [target: avr] cvs-commit at gcc dot gnu.org
2014-08-09 0:58 ` qiyao at gcc dot gnu.org
@ 2014-08-09 1:01 ` qiyao at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: qiyao at gcc dot gnu.org @ 2014-08-09 1:01 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=9053
Yao Qi <qiyao at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
CC| |qiyao at gcc dot gnu.org
Resolution|--- |FIXED
--- Comment #5 from Yao Qi <qiyao at gcc dot gnu.org> ---
GDB on longer supports querying packet size (when LENGTH and OFFSET are zero),
and the corresponding code becomes dead. Remove the dead code and close this
PR.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20050524194801.9053.j@uriah.heep.sax.de>]
end of thread, other threads:[~2014-08-09 1:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-9053-4717@http.sourceware.org/bugzilla/>
2014-08-09 0:56 ` [Bug remote/9053] remote_xfer_partial(): packet size probe fails when LENGTH and OFFSET are zero [target: avr] cvs-commit at gcc dot gnu.org
2014-08-09 0:58 ` qiyao at gcc dot gnu.org
2014-08-09 1:01 ` qiyao at gcc dot gnu.org
[not found] <20050524194801.9053.j@uriah.heep.sax.de>
2008-12-24 19:14 ` pedro at codesourcery dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).