public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Enable hardware breakpoints for gdbserver on Windows
@ 2020-06-07 18:24 gdb-buildbot
  2020-06-07 18:24 ` Failures on Fedora-i686, branch master gdb-buildbot
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: gdb-buildbot @ 2020-06-07 18:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 013707794a67269dd34fd8ae6e354e982c547dc0 ***

commit 013707794a67269dd34fd8ae6e354e982c547dc0
Author:     Hannes Domani <ssbssa@yahoo.de>
AuthorDate: Mon May 11 19:18:31 2020 +0200
Commit:     Hannes Domani <ssbssa@yahoo.de>
CommitDate: Fri May 15 10:55:21 2020 +0200

    Enable hardware breakpoints for gdbserver on Windows
    
    When trying to use hardware breakpoints with gdbserver you get this error:
    
    (gdb) hbreak main
    Hardware assisted breakpoint 2 at 0x40162d: file gdb-9493.c, line 5.
    (gdb) c
    Continuing.
    Warning:
    Cannot insert hardware breakpoint 2.
    Could not insert hardware breakpoints:
    You may have requested too many hardware breakpoints/watchpoints.
    
    It turns out the respective types just needed to be added to the
    appropriate callback functions, because x86_dr_(insert|remove)_watchpoint
    already handles them.
    
    gdbserver/ChangeLog:
    
    2020-05-15  Hannes Domani  <ssbssa@yahoo.de>
    
            * win32-i386-low.cc (i386_supports_z_point_type): Handle
            Z_PACKET_HW_BP z_type.
            (i386_insert_point): Handle raw_bkpt_type type.
            (i386_remove_point): Likewise.

diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index 4853463d05..d2b2444d09 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,10 @@
+2020-05-15  Hannes Domani  <ssbssa@yahoo.de>
+
+	* win32-i386-low.cc (i386_supports_z_point_type): Handle
+	Z_PACKET_HW_BP z_type.
+	(i386_insert_point): Handle raw_bkpt_type type.
+	(i386_remove_point): Likewise.
+
 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 
 	* configure.srv <x86_64-*-mingw*, x86_64-*-cygwin*> (srv_tgtobj):
diff --git a/gdbserver/win32-i386-low.cc b/gdbserver/win32-i386-low.cc
index 389ec49284..410f10a7c2 100644
--- a/gdbserver/win32-i386-low.cc
+++ b/gdbserver/win32-i386-low.cc
@@ -162,6 +162,7 @@ i386_supports_z_point_type (char z_type)
 {
   switch (z_type)
     {
+    case Z_PACKET_HW_BP:
     case Z_PACKET_WRITE_WP:
     case Z_PACKET_ACCESS_WP:
       return 1;
@@ -176,6 +177,7 @@ i386_insert_point (enum raw_bkpt_type type, CORE_ADDR addr,
 {
   switch (type)
     {
+    case raw_bkpt_type_hw:
     case raw_bkpt_type_write_wp:
     case raw_bkpt_type_access_wp:
       {
@@ -197,6 +199,7 @@ i386_remove_point (enum raw_bkpt_type type, CORE_ADDR addr,
 {
   switch (type)
     {
+    case raw_bkpt_type_hw:
     case raw_bkpt_type_write_wp:
     case raw_bkpt_type_access_wp:
       {


^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-06-07 21:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-07 18:24 [binutils-gdb] Enable hardware breakpoints for gdbserver on Windows gdb-buildbot
2020-06-07 18:24 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-06-07 18:39 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-06-07 18:58 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-06-07 19:14 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-06-07 19:42 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-06-07 19:58 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-06-07 20:59 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-06-07 21:14 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).