[binutils-gdb] Fix gdbserver/MI testing regression

[binutils-gdb] Fix gdbserver/MI testing regression

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT 038d48680941f014349256aeb7bab14b3f01d58e ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 038d48680941f014349256aeb7bab14b3f01d58e

Fix gdbserver/MI testing regression

Commit 51f77c3704a6 ("Add testing infrastruture bits for running with
MI on a separate UI") broke MI testing with native-gdbserver:

 $ make check RUNTESTFLAGS="--target_board=native-gdbserver mi-var-child.exp"
	 ...
 Running .../src/binutils-gdb/gdb/testsuite/gdb.mi/mi-var-child.exp ...
 can't unset "inferior_spawn_id": no such variable
     while executing
 "unset inferior_spawn_id"
     (procedure "close_gdbserver" line 20)
     invoked from within
 "close_gdbserver"
 ...

When testing with gdbserver, gdb_exit is overridden with a special
version that calls close_gdbserver, which clears inferior_spawn_id.
The problem is that the commit mentioned above made
gdb_exit/mi_gdb_exit clear inferior_spawn_id too, and clearing a
non-existing variable is a tcl error.

Since gdb_exit/mi_gdb_exit always clears inferior_spawn_id now, the
fix is simply to stop clearing it in close_gdbserver.

gdb/testsuite/
2016-06-30  Pedro Alves  <palves@redhat.com>

	* lib/gdbserver-support.exp (close_gdbserver, gdb_exit): Don't
	unset inferior_spawn_id.

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/3879>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-x86_64-native-extended-gdbserver-m32/.git/tree/?h=master&id=e610fd7de4c277189f048075347c5fea623b6900>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/win_fu_syms.exp: compilation foo.adb
PASS -> FAIL: gdb.base/info-os.exp: get process list
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail;hb=5eec9e4>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail.table;hb=5eec9e4>

Failures on Fedora-ppc64be-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-cc-with-index/builds/3813>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Debian-i686, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-i686

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-i686/builds/3773>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-i686/.git/tree/?h=master&id=7e85b0674466135e7cdbfd76bc5102022580c75d>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: setup: unbreak loop in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: continue
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686/xfails/master/xfail.table;hb=b49a91b>

Failures on Fedora-ppc64be-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-m64/builds/3816>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Fedora-ppc64be-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-gdbserver-m64/builds/3810>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Debian-i686-native-extended-gdbserver, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-i686

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-i686-native-extended-gdbserver/builds/3755>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-i686-native-extended-gdbserver/.git/tree/?h=master&id=5595ca94d1e820240864c8ff7201215e7bce3051>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: step: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: step: setup: unbreak loop in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: step: step
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686-native-extended-gdbserver/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686-native-extended-gdbserver/xfails/master/xfail.table;hb=b49a91b>

Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-extended-gdbserver-m64/builds/3818>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-extended-gdbserver-m64/builds/3751>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/3439>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-s390x-m64/.git/tree/?h=master&id=cb78dcb764c57c9445d01d21e127c2cd3a3baf54>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/thread-specific-bp.exp: non-stop: continue to end
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail;hb=2492e84>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail.table;hb=2492e84>

Failures on Fedora-ppc64le-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-cc-with-index/builds/3729>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Fedora-ppc64le-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-gdbserver-m64/builds/3739>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Debian-s390x-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-wheezy-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/2582>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Fedora-ppc64le-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-m64/builds/3730>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 038d48680941f014349256aeb7bab14b3f01d58e>

Failures on Ubuntu-AArch64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-aarch64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch64-native-gdbserver-m64/builds/122>

Commit(s) tested:
	038d48680941f014349256aeb7bab14b3f01d58e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Fix gdbserver/MI testing regression

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Ubuntu-AArch64-native-gdbserver-m64/.git/tree/?h=master&id=88fa6c5809a6bb6d4a580085280f6ba8fa2eb481>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail;hb=>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Ubuntu-AArch64-native-gdbserver-m64/xfails/master/xfail.table;hb=>