public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Change some tui_data_window methods to be private Date: Wed, 21 Aug 2019 14:46:00 -0000 [thread overview] Message-ID: <04c72a68e073e54aabbec004154f45fdb4026d3d@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 04c72a68e073e54aabbec004154f45fdb4026d3d *** commit 04c72a68e073e54aabbec004154f45fdb4026d3d Author: Tom Tromey <tom@tromey.com> AuthorDate: Sun Jul 14 08:25:43 2019 -0600 Commit: Tom Tromey <tom@tromey.com> CommitDate: Tue Aug 20 16:45:50 2019 -0600 Change some tui_data_window methods to be private Turning various calls into methods has made it possible to now change some tui_data_window methods to be private. 2019-08-20 Tom Tromey <tom@tromey.com> * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no, line_from_reg_element_no, first_reg_element_no_inline, display_all_data, delete_data_content_windows, erase_data_content>: Now private. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b8b062fc3e..41d02a6b49 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2019-08-20 Tom Tromey <tom@tromey.com> + + * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no, + line_from_reg_element_no, first_reg_element_no_inline, + display_all_data, delete_data_content_windows, + erase_data_content>: Now private. + 2019-08-20 Tom Tromey <tom@tromey.com> * tui/tui-wingeneral.c (box_win): Change type of highlight_flag. diff --git a/gdb/tui/tui-regs.h b/gdb/tui/tui-regs.h index de44557880..95e944038c 100644 --- a/gdb/tui/tui-regs.h +++ b/gdb/tui/tui-regs.h @@ -68,28 +68,20 @@ struct tui_data_window : public tui_win_info int regs_column_count = 0; struct reggroup *current_group = nullptr; - /* Answer the number of the last line in the regs display. If there - are no registers (-1) is returned. */ - int last_regs_line_no () const; + void check_register_values (struct frame_info *frame); - /* Answer the line number that the register element at element_no is - on. If element_no is greater than the number of register - elements there are, -1 is returned. */ - int line_from_reg_element_no (int element_no) const; + void show_registers (struct reggroup *group); - /* Answer the index of the first element in line_no. If line_no is - past the register area (-1) is returned. */ - int first_reg_element_no_inline (int line_no) const; +protected: - /* Displays the data that is in the data window's content. It does - not set the content. */ - void display_all_data (); + void do_scroll_vertical (int num_to_scroll) override; + void do_scroll_horizontal (int num_to_scroll) override + { + } - /* Delete all the item windows in the data window. This is usually - done when the data window is scrolled. */ - void delete_data_content_windows (); + void rerender () override; - void erase_data_content (const char *prompt); +private: /* Display the registers in the content from 'start_element_no' until the end of the register content or the end of the display @@ -102,17 +94,6 @@ struct tui_data_window : public tui_win_info started from. If nothing is displayed (-1) is returned. */ int display_registers_from_line (int line_no); - void check_register_values (struct frame_info *frame); - - void show_registers (struct reggroup *group); - -protected: - - void do_scroll_vertical (int num_to_scroll) override; - void do_scroll_horizontal (int num_to_scroll) override - { - } - /* Return the index of the first element displayed. If none are displayed, then return -1. */ int first_data_item_displayed (); @@ -123,11 +104,32 @@ protected: display off the end of the register display. */ void display_reg_element_at_line (int start_element_no, int start_line_no); - void rerender () override; - void show_register_group (struct reggroup *group, struct frame_info *frame, int refresh_values_only); + + /* Answer the number of the last line in the regs display. If there + are no registers (-1) is returned. */ + int last_regs_line_no () const; + + /* Answer the line number that the register element at element_no is + on. If element_no is greater than the number of register + elements there are, -1 is returned. */ + int line_from_reg_element_no (int element_no) const; + + /* Answer the index of the first element in line_no. If line_no is + past the register area (-1) is returned. */ + int first_reg_element_no_inline (int line_no) const; + + /* Displays the data that is in the data window's content. It does + not set the content. */ + void display_all_data (); + + /* Delete all the item windows in the data window. This is usually + done when the data window is scrolled. */ + void delete_data_content_windows (); + + void erase_data_content (const char *prompt); }; #endif /* TUI_TUI_REGS_H */
next reply other threads:[~2019-08-21 14:34 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-21 14:46 gdb-buildbot [this message] 2019-08-21 14:48 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-cc-with-index, branch master *** BREAKAGE *** gdb-buildbot 2019-08-21 14:49 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m32, " gdb-buildbot 2019-08-21 14:58 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m64, " gdb-buildbot 2019-08-21 15:00 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot 2019-08-21 15:01 ` Failures on Fedora-i686, branch master gdb-buildbot 2019-08-21 18:06 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-gdbserver-m32, branch master *** BREAKAGE *** gdb-buildbot 2019-08-21 18:06 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot 2019-08-21 18:06 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=04c72a68e073e54aabbec004154f45fdb4026d3d@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).