public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Remove some defines from tui-data.h Date: Wed, 21 Aug 2019 06:33:00 -0000 [thread overview] Message-ID: <072272ce055b0234ee9622a80d217f9d1f8083b3@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 072272ce055b0234ee9622a80d217f9d1f8083b3 *** commit 072272ce055b0234ee9622a80d217f9d1f8083b3 Author: Tom Tromey <tom@tromey.com> AuthorDate: Sat Jul 13 18:30:53 2019 -0600 Commit: Tom Tromey <tom@tromey.com> CommitDate: Tue Aug 20 16:45:50 2019 -0600 Remove some defines from tui-data.h This removes the HILITE and NO_HILITE defines from tui-data.h, in favor of simply passing a bool to box_win. 2019-08-20 Tom Tromey <tom@tromey.com> * tui/tui-wingeneral.c (box_win): Change type of highlight_flag. (tui_unhighlight_win, tui_highlight_win) (tui_win_info::make_window): Update. * tui/tui-data.h (HILITE, NO_HILITE): Remove. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ea228474d8..b8b062fc3e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2019-08-20 Tom Tromey <tom@tromey.com> + + * tui/tui-wingeneral.c (box_win): Change type of highlight_flag. + (tui_unhighlight_win, tui_highlight_win) + (tui_win_info::make_window): Update. + * tui/tui-data.h (HILITE, NO_HILITE): Remove. + 2019-08-20 Tom Tromey <tom@tromey.com> * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX) diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h index dda15d1fbe..6dfea41d49 100644 --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -102,8 +102,6 @@ public: #define CMD_NAME "cmd" #define DATA_NAME "regs" #define DISASSEM_NAME "asm" -#define HILITE TRUE -#define NO_HILITE FALSE #define MIN_WIN_HEIGHT 3 #define MIN_CMD_WIN_HEIGHT 3 diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c index 5fa4cfd9ee..ab0363f856 100644 --- a/gdb/tui/tui-wingeneral.c +++ b/gdb/tui/tui-wingeneral.c @@ -56,7 +56,7 @@ tui_delete_win (WINDOW *window) /* Draw a border arround the window. */ static void box_win (struct tui_win_info *win_info, - int highlight_flag) + bool highlight_flag) { if (win_info && win_info->handle) { @@ -64,7 +64,7 @@ box_win (struct tui_win_info *win_info, int attrs; win = win_info->handle; - if (highlight_flag == HILITE) + if (highlight_flag) attrs = tui_active_border_attrs; else attrs = tui_border_attrs; @@ -92,7 +92,7 @@ tui_unhighlight_win (struct tui_win_info *win_info) && win_info->can_highlight && win_info->handle != NULL) { - box_win (win_info, NO_HILITE); + box_win (win_info, false); win_info->refresh_window (); win_info->set_highlight (false); } @@ -106,7 +106,7 @@ tui_highlight_win (struct tui_win_info *win_info) && win_info->can_highlight && win_info->handle != NULL) { - box_win (win_info, HILITE); + box_win (win_info, true); win_info->refresh_window (); win_info->set_highlight (true); } @@ -138,7 +138,7 @@ tui_win_info::make_window () { tui_gen_win_info::make_window (); if (handle != NULL && can_box ()) - box_win (this, NO_HILITE); + box_win (this, false); } /* We can't really make windows visible, or invisible. So we have to
next reply other threads:[~2019-08-21 5:54 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-21 6:33 gdb-buildbot [this message] 2019-08-21 6:14 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot 2019-08-21 14:11 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-cc-with-index, branch master *** BREAKAGE *** gdb-buildbot 2019-08-21 14:14 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m32, " gdb-buildbot 2019-08-21 14:19 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-m64, " gdb-buildbot 2019-08-21 14:26 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot 2019-08-21 14:34 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot 2019-08-21 14:34 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot 2019-08-21 14:43 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=072272ce055b0234ee9622a80d217f9d1f8083b3@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).