public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] gdb: small cleanup in breakpoint.c's includes Date: Fri, 18 Oct 2019 05:41:00 -0000 [thread overview] Message-ID: <073bbbb058e36c60e5d30a4a25b48307429b7128@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 073bbbb058e36c60e5d30a4a25b48307429b7128 *** commit 073bbbb058e36c60e5d30a4a25b48307429b7128 Author: Simon Marchi <simon.marchi@polymtl.ca> AuthorDate: Sat Oct 12 23:46:15 2019 -0400 Commit: Simon Marchi <simon.marchi@polymtl.ca> CommitDate: Sat Oct 12 23:46:16 2019 -0400 gdb: small cleanup in breakpoint.c's includes In an attempt to reduce the number of files re-build when some headers are touched, I ran include-what-you-use with breakpoint.c as a guinea pig. It revealed a few files that were unnecessary to include, which this patch removes. breakpoint.c uses tilde_expand from readline, hence the necessity to include tilde.h. AFAIK, it's fine to include just that, and not the whole readline headers. include-what-you-use also reported many header files that should be included but aren't, I suppose that breakpoint.c currently includes them indirectly. For now I'll pretend I didn't see that :). gdb/ChangeLog: * breakpoint.c: Remove some includes: continuations.h, skip.h, mi/mi-main.h, readline/readline.h, readline/history.h. Add include: readline/tilde.h. -#include "skip.h" #include "ax-gdb.h" #include "dummy-frame.h" #include "interps.h" @@ -69,11 +67,9 @@ #include "thread-fsm.h" #include "tid-parse.h" #include "cli/cli-style.h" -#include "mi/mi-main.h" /* readline include files */ -#include "readline/readline.h" -#include "readline/history.h" +#include "readline/tilde.h" /* readline defines this. */ #undef savestring Change-Id: I88bfe9071f2f973fd84caaf04b95c33a4dfb33de diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e6e1489fcf..381bdc41bc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-10-12 Simon Marchi <simon.marchi@polymtl.ca> + + * breakpoint.c: Remove some includes: continuations.h, skip.h, + mi/mi-main.h, readline/readline.h, readline/history.h. Add + include: readline/tilde.h. + 2019-10-12 Christian Biesinger <cbiesinger@google.com> * remote.c (remote_target::get_trace_status): Remove declaration of diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 0a70516338..31f4005ec7 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -59,9 +59,7 @@ #include "gdb_regex.h" #include "probe.h" #include "cli/cli-utils.h" -#include "continuations.h" #include "stack.h" -#include "skip.h" #include "ax-gdb.h" #include "dummy-frame.h" #include "interps.h" @@ -69,11 +67,9 @@ #include "thread-fsm.h" #include "tid-parse.h" #include "cli/cli-style.h" -#include "mi/mi-main.h" /* readline include files */ -#include "readline/readline.h" -#include "readline/history.h" +#include "readline/tilde.h" /* readline defines this. */ #undef savestring
next reply other threads:[~2019-10-18 5:41 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-18 5:41 gdb-buildbot [this message] 2019-10-18 5:41 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot 2019-10-18 7:08 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot 2019-10-18 7:57 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot 2019-10-25 11:49 ` Failures on Fedora-x86_64-m32, " gdb-buildbot 2019-10-25 12:29 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot 2019-10-25 12:35 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=073bbbb058e36c60e5d30a4a25b48307429b7128@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).