public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix FAIL in gdb.base/printcmds.exp
Date: Sat, 28 Mar 2020 23:58:33 -0400	[thread overview]
Message-ID: <09546b56ede31ca2b401e9b03466e8e1fb84d85f@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 09546b56ede31ca2b401e9b03466e8e1fb84d85f ***

commit 09546b56ede31ca2b401e9b03466e8e1fb84d85f
Author:     Tom de Vries <tdevries@suse.de>
AuthorDate: Sat Mar 14 10:17:10 2020 +0100
Commit:     Tom de Vries <tdevries@suse.de>
CommitDate: Sat Mar 14 10:17:10 2020 +0100

    [gdb/testsuite] Fix FAIL in gdb.base/printcmds.exp
    
    With test-case gdb.base/printcmds.exp, I run into:
    ...
    (gdb) print teststring2^M
    $563 = (charptr) "more contents"^M
    (gdb) FAIL: gdb.base/printcmds.exp: print teststring2
    ...
    
    The corresponding test is:
    ...
         gdb_test "print teststring2" " = (charptr) \"more contents\""
    ...
    
    Fix the FAIL by adding the missing quoting for the parentheses around charptr.
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2020-03-14  Tom de Vries  <tdevries@suse.de>
    
            * gdb.base/printcmds.exp: Add missing quoting for "print
            teststring2".

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index ec22de89d5..9f65a4eaa8 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-14  Tom de Vries  <tdevries@suse.de>
+
+	* gdb.base/printcmds.exp: Add missing quoting for "print
+	teststring2".
+
 2020-03-13  Tom Tromey  <tom@tromey.com>
 
 	* gdb.base/printcmds.exp (test_print_strings): Add regression
diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp
index 2c8baad5aa..066e7fce87 100644
--- a/gdb/testsuite/gdb.base/printcmds.exp
+++ b/gdb/testsuite/gdb.base/printcmds.exp
@@ -520,7 +520,7 @@ proc test_print_strings {} {
 	" = (.unsigned char .. )?\"teststring contents\"" "p teststring with elements set to 20"
 
     gdb_test "print teststring2" \
-	" = (charptr) \"more contents\""
+	" = \\(charptr\\) \"more contents\""
 
     gdb_test_no_output "set print elements 8"
 


             reply	other threads:[~2020-03-29  3:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-29  3:58 gdb-buildbot [this message]
2020-03-29  3:58 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-03-29  4:14 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-03-29  4:45 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-03-29  5:12 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-03-29  5:27 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-04-01 12:46 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-04-01 14:33 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09546b56ede31ca2b401e9b03466e8e1fb84d85f@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).