public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Use scoped_value_mark in dwarf2_evaluate_loc_desc_full
Date: Fri, 13 Jan 2017 05:07:00 -0000	[thread overview]
Message-ID: <0cf082277804ba3747be70a4013019f68b92bb84@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 0cf082277804ba3747be70a4013019f68b92bb84 ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 0cf082277804ba3747be70a4013019f68b92bb84

Use scoped_value_mark in dwarf2_evaluate_loc_desc_full

This changes dwarf2_evaluate_loc_desc_full to use scoped_value_mark.

Note that this function previously called do_cleanup using the same
cleanup multiple times.  I had thought this was buggy, but re-reading
make_my_cleanup2 indicates that it is not.  Nevertheless it is
surprising, and at least one of the calls (the one that is completely
removed in this patch) seems to have been done under the assumption
that it would still have some effect.

2017-01-10  Tom Tromey  <tom@tromey.com>

	* value.h (scoped_value_mark::~scoped_value_mark): Call
	free_to_mark.
	(scoped_value_mark::free_to_mark): New method.
	* dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use
	scoped_value_mark.


             reply	other threads:[~2017-01-13  5:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  5:07 sergiodj+buildbot [this message]
2017-01-13  5:06 ` Failures on Fedora-x86_64-m64, branch master sergiodj+buildbot
2017-01-13  5:11 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2017-01-13  5:28 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-01-13  5:37 ` Failures on Fedora-i686, " sergiodj+buildbot
2017-01-13  5:58 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2017-01-13  6:04 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2017-01-14  3:51 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-01-14  4:03 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2017-01-14  4:33 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2017-01-21  3:17 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2017-01-21  4:21 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-01-21  5:03 ` Failures on Fedora-ppc64be-cc-with-index, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cf082277804ba3747be70a4013019f68b92bb84@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).