From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105086 invoked by alias); 20 Aug 2019 23:37:33 -0000 Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-testers-owner@sourceware.org Received: (qmail 105075 invoked by uid 89); 20 Aug 2019 23:37:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Aug 2019 23:37:31 +0000 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] Remove NULL check from tui_reg_command From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Message-Id: <0f8d8876d98305671a19b5bf88f125d4d02c7e0f@gdb-build> Date: Wed, 21 Aug 2019 00:24:00 -0000 X-SW-Source: 2019-q3/txt/msg03077.txt.bz2 *** TEST RESULTS FOR COMMIT 0f8d8876d98305671a19b5bf88f125d4d02c7e0f *** commit 0f8d8876d98305671a19b5bf88f125d4d02c7e0f Author: Tom Tromey AuthorDate: Sat Jul 13 15:53:44 2019 -0600 Commit: Tom Tromey CommitDate: Tue Aug 20 16:22:04 2019 -0600 Remove NULL check from tui_reg_command tui_reg_command has an unnecessary NULL check. The preceding call to tui_reg_layout will ensure the window exists. This patch removes the check. gdb/ChangeLog 2019-08-20 Tom Tromey * tui/tui-regs.c (tui_reg_command): Remove NULL check. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c4a1179ce0..ce64e7accc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2019-08-20 Tom Tromey + + * tui/tui-regs.c (tui_reg_command): Remove NULL check. + 2019-08-20 Tom Tromey * tui/tui-source.h (struct tui_source_window): Update. diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 8fcb7bc46b..b3c7ce627b 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -669,9 +669,7 @@ tui_reg_command (const char *args, int from_tty) if (TUI_DATA_WIN == NULL || !TUI_DATA_WIN->is_visible ()) tui_reg_layout (); - struct reggroup *current_group = NULL; - if (TUI_DATA_WIN != NULL) - current_group = TUI_DATA_WIN->current_group; + struct reggroup *current_group = TUI_DATA_WIN->current_group; if (strncmp (args, "next", len) == 0) match = tui_reg_next (current_group, gdbarch); else if (strncmp (args, "prev", len) == 0)