public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove NULL check from tui_reg_command
@ 2019-08-21  0:24 gdb-buildbot
  2019-08-21  0:26 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: gdb-buildbot @ 2019-08-21  0:24 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 0f8d8876d98305671a19b5bf88f125d4d02c7e0f ***

commit 0f8d8876d98305671a19b5bf88f125d4d02c7e0f
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Sat Jul 13 15:53:44 2019 -0600
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Tue Aug 20 16:22:04 2019 -0600

    Remove NULL check from tui_reg_command
    
    tui_reg_command has an unnecessary NULL check.  The preceding call to
    tui_reg_layout will ensure the window exists.  This patch removes the
    check.
    
    gdb/ChangeLog
    2019-08-20  Tom Tromey  <tom@tromey.com>
    
            * tui/tui-regs.c (tui_reg_command): Remove NULL check.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c4a1179ce0..ce64e7accc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-08-20  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui-regs.c (tui_reg_command): Remove NULL check.
+
 2019-08-20  Tom Tromey  <tom@tromey.com>
 
 	* tui/tui-source.h (struct tui_source_window): Update.
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 8fcb7bc46b..b3c7ce627b 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -669,9 +669,7 @@ tui_reg_command (const char *args, int from_tty)
       if (TUI_DATA_WIN == NULL || !TUI_DATA_WIN->is_visible ())
 	tui_reg_layout ();
 
-      struct reggroup *current_group = NULL;
-      if (TUI_DATA_WIN != NULL)
-	current_group = TUI_DATA_WIN->current_group;
+      struct reggroup *current_group = TUI_DATA_WIN->current_group;
       if (strncmp (args, "next", len) == 0)
 	match = tui_reg_next (current_group, gdbarch);
       else if (strncmp (args, "prev", len) == 0)


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-08-21  2:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21  0:24 [binutils-gdb] Remove NULL check from tui_reg_command gdb-buildbot
2019-08-21  0:26 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-08-21  1:41 ` Failures on Fedora-i686, " gdb-buildbot
2019-08-21  2:33 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-08-21  2:41 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-08-21  2:54 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-08-21  2:54 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-08-21  2:59 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).