From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-testers-return-141528-listarch-gdb-testers=sources.redhat.com@sourceware.org>
Received: (qmail 12034 invoked by alias); 23 Jun 2019 14:07:45 -0000
Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-testers.sourceware.org>
List-Subscribe: <mailto:gdb-testers-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-testers/>
List-Post: <mailto:gdb-testers@sourceware.org>
List-Help: <mailto:gdb-testers-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-testers-owner@sourceware.org
Received: (qmail 12026 invoked by uid 89); 23 Jun 2019 14:07:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-15.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: kwanyin.sergiodj.net
Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Jun 2019 14:07:44 +0000
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [binutils-gdb] PR24689 again, string table corruption
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Message-Id: <14b2a8e4244a29208ad430167860a0f01b20f215@gdb-build>
Date: Mon, 24 Jun 2019 11:49:00 -0000
X-SW-Source: 2019-q2/txt/msg06570.txt.bz2

*** TEST RESULTS FOR COMMIT 14b2a8e4244a29208ad430167860a0f01b20f215 ***

commit 14b2a8e4244a29208ad430167860a0f01b20f215
Author:     Alan Modra <amodra@gmail.com>
AuthorDate: Sun Jun 23 12:10:02 2019 +0930
Commit:     Alan Modra <amodra@gmail.com>
CommitDate: Sun Jun 23 14:24:45 2019 +0930

    PR24689 again, string table corruption
    
    Depending on optimisation level and gcc version, git commit 890f750a3b
    introduces a false positive warning that i_shdrp may be used
    uninitialized.
    
            PR 24689
            * elfcode.h (elf_object_p): Warning fix.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index bc7671e9ea..964ab71b20 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2019-06-23  Alan Modra  <amodra@gmail.com>
+
+	PR 24689
+	* elfcode.h (elf_object_p): Warning fix.
+
 2019-06-21  Alan Modra  <amodra@gmail.com>
 
 	PR 24689
diff --git a/bfd/elfcode.h b/bfd/elfcode.h
index 5180f79a74..9a73c3b71f 100644
--- a/bfd/elfcode.h
+++ b/bfd/elfcode.h
@@ -749,11 +749,7 @@ elf_object_p (bfd *abfd)
 		  != 0))
 	    abfd->flags &= ~D_PAGED;
 	}
-    }
 
-  /* A further sanity check.  */
-  if (i_ehdrp->e_shnum != 0)
-    {
       if (i_ehdrp->e_shstrndx >= elf_numsections (abfd)
 	  || i_shdrp[i_ehdrp->e_shstrndx].sh_type != SHT_STRTAB)
 	{