[binutils-gdb] Avoid find_thread_ptid with null_ptid

[binutils-gdb] Avoid find_thread_ptid with null_ptid

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT 151bb4a5059e73934f7bc61318efaaffe0c91b81 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 151bb4a5059e73934f7bc61318efaaffe0c91b81

Avoid find_thread_ptid with null_ptid

With a following patch, find_thread_ptid will first find the inferior
for the passed-in ptid, using find_inferior_pid, and then look for the
thread in that inferior's thread list.  If we pass down null_ptid to
find_thread_ptid then that means we'll end up passing 0 to
find_inferior_pid, which hits this assertion:

>   struct inferior *
>   find_inferior_pid (int pid)
>   {
>     struct inferior *inf;
>
>     /* Looking for inferior pid == 0 is always wrong, and indicative of
>	a bug somewhere else.  There may be more than one with pid == 0,
>	for instance.  */
>     gdb_assert (pid != 0);

This patch prepares for the change, by avoiding passing down null_ptid
to find_thread_ptid or to functions that naturally use it, such as the
target_pid_to_str call in inferior.c:add_inferior.  In that latter
case, the patch changes GDB output,

from:
 (gdb) add-inferior
 [New inferior 2 (process 0)]

to:
 (gdb) add-inferior
 [New inferior 2]

which seems like a good change to me.  It might not even make sense to
talk about "process" for the current target, for example.

The python_on_normal_stop change ends up avoiding looking up the
same thread twice (inferior_thread also does a look up).

gdb/ChangeLog:
2018-11-22  Pedro Alves  <palves@redhat.com>

	* cli/cli-interp.c (cli_on_user_selected_context_changed): Use
	inferior_thread instead of find_thread_ptid, and only when
	inferior_ptid is not null_ptid.
	* inferior.c (add_inferior): Don't include target_pid_to_str
	output when the inferior is not started.
	* python/py-inferior.c (python_on_normal_stop): Don't use
	find_thread_ptid.
	(tui_on_user_selected_context_changed): Use inferior_thread
	instead of find_thread_ptid, and only when inferior_ptid is not
	null_ptid.

Failures on RHEL-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/8830>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail?id=45db1d88>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail.table?id=45db1d88>

Failures on Fedora-i686, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/11529>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-i686/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
new FAIL: gdb.base/catch-syscall.exp: multiple targets: insert catch syscall on syscall 1 -- write on i386:x86-64
new FAIL: gdb.python/py-finish-breakpoint2.exp: check FinishBreakpoint in catch
new FAIL: gdb.python/py-finish-breakpoint2.exp: check finish BP removal
new FAIL: gdb.python/py-finish-breakpoint2.exp: continue to second exception
new FAIL: gdb.python/py-finish-breakpoint2.exp: set FinishBP after the exception
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
new KFAIL: gdb.xml/tdesc-arch.exp: set tdesc filename tdesc-arch.xml
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail?id=45f75fca>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail.table?id=45f75fca>

Failures on Fedora-x86_64-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/11443>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail?id=6009c31a>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table?id=6009c31a>

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/10154>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail?id=42cc8929>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail.table?id=42cc8929>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/11478>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail?id=98f12db2>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table?id=98f12db2>

Failures on Debian-s390x-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/6993>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail?id=f92d7f7b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail.table?id=f92d7f7b>

Failures on Fedora-x86_64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/11578>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail?id=0abd3f37>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail.table?id=0abd3f37>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/11445>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail?id=692a6515>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table?id=692a6515>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/11207>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> FAIL: gdb.base/foll-exec-mode.exp: same,continue,no_infswitch: use correct executable
PASS -> FAIL: gdb.base/foll-exec-mode.exp: same,next,no_infswitch: use correct executable
PASS -> FAIL: gdb.base/fork-print-inferior-events.exp: print_inferior_events=off: follow_fork_mode=parent: detach_on_fork=off: run
PASS -> FAIL: gdb.base/multi-forks.exp: info inferior 3
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> UNRESOLVED: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: continue
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail?id=d39bf374>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m32/xfails/master/xfail.table?id=d39bf374>

Failures on Debian-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/6949>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=8: wait for stops
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail?id=a224ef13>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail.table?id=a224ef13>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/11215>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m32/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

*** Diff to previous build ***
============================
new UNRESOLVED: gdb.base/interrupt.exp: echo more data
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail?id=16dbb5a7>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail.table?id=16dbb5a7>

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu16-aarch64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-Aarch64-native-extended-gdbserver-m64/builds/189>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu16-aarch64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-Aarch64-native-gdbserver-m64/builds/4558>

Commit(s) tested:
	151bb4a5059e73934f7bc61318efaaffe0c91b81

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Avoid find_thread_ptid with null_ptid

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-Aarch64-native-gdbserver-m64/15/151bb4a5059e73934f7bc61318efaaffe0c91b81/>