public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] gdb/riscv: Use legacy register numbers in default target description Date: Wed, 27 Feb 2019 04:51:00 -0000 [thread overview] Message-ID: <172fb711a2336b62cf8d58bbb4b27dc71ca8c02d@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 172fb711a2336b62cf8d58bbb4b27dc71ca8c02d *** Author: Andrew Burgess <andrew.burgess@embecosm.com> Branch: master Commit: 172fb711a2336b62cf8d58bbb4b27dc71ca8c02d gdb/riscv: Use legacy register numbers in default target description When the target description support was added to RISC-V, the register numbers assigned to the fflags, frm, and fcsr control registers in the default target descriptions didn't match the register numbers used by GDB before the target description support was added. What this means is that if a tools exists in the wild that is using hard-coded register number, setup to match GDB's old numbering, then this will have been broken (for fflags, frm, and fcsr) by the move to target descriptions. QEMU is such a tool. There are a couple of solutions that could be used to work around this issue: - The user can create their own xml description file with the register numbers setup to match their old tool, then load this by telling GDB 'set tdesc filename FILENAME'. - Update their old tool to use the newer default numbering scheme, or better yet add proper target description support to their tool. - We could have RISC-V GDB change to maintain the old defaults. This patch changes GDB back to using the old numbering scheme. This change is only visible to remote targets that don't supply their own xml description file and instead rely on GDB's default numbering. Note that even though 32bit-cpu.xml and 64bit-cpu.xml have changed, the corresponding .c file has not, this is because the numbering added to the registers in the xml files is number 0, this doesn't result in any new C code being generated . gdb/ChangeLog: * features/riscv/32bit-cpu.xml: Add register numbers. * features/riscv/32bit-fpu.c: Regenerate. * features/riscv/32bit-fpu.xml: Add register numbers. * features/riscv/64bit-cpu.xml: Add register numbers. * features/riscv/64bit-fpu.c: Regenerate. * features/riscv/64bit-fpu.xml: Add register numbers.
next reply other threads:[~2019-02-27 4:51 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-27 4:51 sergiodj+buildbot [this message] 2019-02-27 4:51 ` Failures on Debian-s390x-native-extended-gdbserver-m64, branch master sergiodj+buildbot 2019-02-27 5:38 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2019-02-27 7:11 ` Failures on Fedora-i686, " sergiodj+buildbot 2019-02-27 8:07 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot 2019-02-27 8:31 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2019-02-27 8:45 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2019-02-27 9:00 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=172fb711a2336b62cf8d58bbb4b27dc71ca8c02d@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).