public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new Date: Mon, 21 May 2018 03:57:00 -0000 [thread overview] Message-ID: <184cde7552b5434196b8380be23b39ff4a5a17e6@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 184cde7552b5434196b8380be23b39ff4a5a17e6 *** Author: Simon Marchi <simon.marchi@polymtl.ca> Branch: master Commit: 184cde7552b5434196b8380be23b39ff4a5a17e6 Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new I realized after pushing that I made a copy-pasto, I had: # define HAVE_IS_TRIVIALLY_COPYABLE 1 instead of # define HAVE_IS_TRIVIALLY_CONSTRUCTIBLE 1 with the consequence that IsMallocable was always std::true_type (and was therefore not enforcing anything). Fixing that mistake triggered a build failure: /home/simark/src/binutils-gdb/gdb/objfiles.c:150:12: required from here /home/simark/src/binutils-gdb/gdb/common/poison.h:228:3: error: static assertion failed: Trying to use XOBNEW with a non-POD data type. I am not sure why I did not see this when I originally wrote the patch (but I saw and fixed other failures). In any case, I swapped XOBNEW with obstack_new to get rid of it. Regtested on the buildbot. gdb/ChangeLog: * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong instance to... (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this. * objfiles.c (get_objfile_bfd_data): Allocate objfile_per_bfd_storage with obstack_new when allocating on obstack.
next reply other threads:[~2018-05-21 3:56 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-21 3:57 sergiodj+buildbot [this message] 2018-05-21 4:31 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot 2018-05-21 4:36 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot 2018-05-21 6:49 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2018-05-21 8:03 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2018-05-29 2:23 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot 2018-05-29 15:41 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-05-29 15:41 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE *** sergiodj+buildbot 2018-07-27 22:14 ` Failures on Ubuntu-AArch32-m32, branch master sergiodj+buildbot 2018-07-28 1:41 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=184cde7552b5434196b8380be23b39ff4a5a17e6@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).