[binutils-gdb] gdbserver/Windows: crash during connection establishment phase

[binutils-gdb] gdbserver/Windows: crash during connection establishment phase

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT 190852c8ac75cb62a737c58edfadfb0e1fcef78a ***

Author: Joel Brobecker <brobecker@adacore.com>
Branch: master
Commit: 190852c8ac75cb62a737c58edfadfb0e1fcef78a

gdbserver/Windows: crash during connection establishment phase

On Windows, starting a new process with GDBserver seems to work,
in the sense that the program does get started, and GDBserver
confirms that it is listening for GDB to connect. However, as soon as
GDB establishes the connection with GDBserver, and starts discussing
with it, GDBserver crashes, with a SEGV.

This SEGV occurs in remote-utils.c::prepare_resume_reply...

  | regp = current_target_desc ()->expedite_regs;
  | [...]
  | while (*regp)

... because, in our case, REGP is NULL.

This patches fixes the issues by adding a parameter to init_target_desc,
in order to make sure that we always provide the list of registers when
we initialize a target description.

gdb/ChangeLog:

        PR server/23158:
        * regformats/regdat.sh: Adjust script, following the addition
        of the new expedite_regs parameter to init_target_desc.

gdb/gdbserver/ChangeLog:

        PR server/23158:
        * tdesc.h (init_target_desc) <expedite_regs>: New parameter.
        * tdesc.c (init_target_desc) <expedite_regs>: New parameter.
        Use it to set the expedite_regs field in the given tdesc.
        * x86-tdesc.h: New file.
        * linux-aarch64-tdesc.c (aarch64_linux_read_description):
        Adjust following the addition of the new expedite_regs parameter
        to init_target_desc.
        * linux-tic6x-low.c (tic6x_read_description): Likewise.
        * linux-x86-tdesc.c: #include "x86-tdesc.h".
        (i386_linux_read_description, amd64_linux_read_description):
        Adjust following the addition of the new expedite_regs parameter
        to init_target_desc.
        * lynx-i386-low.c: #include "x86-tdesc.h".
        (lynx_i386_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.
        * nto-x86-low.c: #include "x86-tdesc.h".
        (nto_x86_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.
        * win32-i386-low.c: #include "x86-tdesc.h".
        (i386_arch_setup): Adjust following the addition of the new
        expedite_regs parameter to init_target_desc.

Failures on RHEL-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/7137>

Commit(s) tested:
	190852c8ac75cb62a737c58edfadfb0e1fcef78a

Author(s) (in the same order as the commits):
	Joel Brobecker <brobecker@adacore.com>

Subject:
	gdbserver/Windows: crash during connection establishment phase

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/19/190852c8ac75cb62a737c58edfadfb0e1fcef78a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail?id=6da72a5>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail.table?id=6da72a5>

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/8470>

Commit(s) tested:
	190852c8ac75cb62a737c58edfadfb0e1fcef78a

Author(s) (in the same order as the commits):
	Joel Brobecker <brobecker@adacore.com>

Subject:
	gdbserver/Windows: crash during connection establishment phase

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/19/190852c8ac75cb62a737c58edfadfb0e1fcef78a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail?id=d48b9f4>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail.table?id=d48b9f4>

Failures on Debian-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/5272>

Commit(s) tested:
	190852c8ac75cb62a737c58edfadfb0e1fcef78a

Author(s) (in the same order as the commits):
	Joel Brobecker <brobecker@adacore.com>

Subject:
	gdbserver/Windows: crash during connection establishment phase

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/19/190852c8ac75cb62a737c58edfadfb0e1fcef78a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail?id=ceb3c6c>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail.table?id=ceb3c6c>

*** COMPILATION FAILED *** Failures on Fedora-i686, branch master *** BREAKAGE ***

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/9659>

Commit(s) tested:
	190852c8ac75cb62a737c58edfadfb0e1fcef78a

Author(s) (in the same order as the commits):
	Joel Brobecker <brobecker@adacore.com>

Subject:
	gdbserver/Windows: crash during connection establishment phase

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-i686/19/190852c8ac75cb62a737c58edfadfb0e1fcef78a/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

checking netdb.h presence... yes
checking for netdb.h... yes
checking netinet/tcp.h usability... yes
checking netinet/tcp.h presence... yes
checking for netinet/tcp.h... yes
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking for pid_t... (cached) yes
checking for vfork.h... (cached) no
checking for fork... (cached) yes
checking for vfork... (cached) yes
checking for working fork... (cached) yes
checking for working vfork... (cached) yes
checking for getauxval... (cached) yes
checking for pread... (cached) yes
checking for pwrite... (cached) yes
checking for pread64... (cached) yes
checking for setns... (cached) yes
checking for ANSI C header files... (cached) yes
checking for working alloca.h... (cached) yes
checking for alloca... (cached) yes
checking for nl_langinfo and CODESET... (cached) yes
checking for linux/perf_event.h... (cached) yes
checking for locale.h... (cached) yes
checking for memory.h... (cached) yes
checking for signal.h... (cached) yes
checking for sys/resource.h... (cached) yes
checking for sys/socket.h... (cached) yes
checking for sys/un.h... (cached) yes
checking for sys/wait.h... (cached) yes
checking for thread_db.h... (cached) yes
checking for wait.h... (cached) yes
checking for termios.h... (cached) yes
checking for fdwalk... (cached) no
checking for getrlimit... (cached) yes
checking for pipe... (cached) yes
checking for pipe2... (cached) yes
checking for socketpair... (cached) yes
checking for sigaction... (cached) yes
checking whether strerror is declared... (cached) yes
checking whether strstr is declared... (cached) yes
checking for sigsetjmp... (cached) yes
checking for sys/ptrace.h... (cached) yes
checking for ptrace.h... (cached) no
checking whether ptrace is declared... (cached) yes
checking return type of ptrace... (cached) long
checking types of arguments for ptrace... (cached) enum __ptrace_request,int,long,long
checking for ust... no
checking compiler warning flags...  -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wsuggest-override -Wimplicit-fallthrough -Wduplicated-cond -Werror
checking for dladdr... yes
checking for long long... (cached) yes
checking size of long long... (cached) 8
checking whether basename is declared... (cached) yes
checking whether ffs is declared... (cached) yes
checking whether asprintf is declared... (cached) yes
checking whether vasprintf is declared... (cached) yes
checking whether snprintf is declared... (cached) yes
checking whether vsnprintf is declared... (cached) yes
checking whether strtol is declared... (cached) yes
checking whether strtoul is declared... (cached) yes
checking whether strtoll is declared... (cached) yes
checking whether strtoull is declared... (cached) yes
checking whether strverscmp is declared... (cached) yes
checking whether strerror is declared... (cached) yes
checking whether perror is declared... yes
checking whether vasprintf is declared... (cached) yes
checking whether vsnprintf is declared... (cached) yes
checking for struct stat.st_blocks... (cached) yes
checking for struct stat.st_blksize... (cached) yes
checking for struct user_regs_struct.fs_base... (cached) no
checking for struct user_regs_struct.gs_base... (cached) no
checking for socklen_t... (cached) yes
checking for Elf32_auxv_t... yes
checking for Elf64_auxv_t... yes
checking if building for x86-64... no
checking for PTRACE_GETREGS... yes
checking for PTRACE_GETFPXREGS... yes
checking for lwpid_t in sys/procfs.h... (cached) yes
checking for psaddr_t in sys/procfs.h... (cached) yes
checking for prgregset_t in sys/procfs.h... (cached) yes
checking for prfpregset_t in sys/procfs.h... (cached) yes
checking for elf_fpregset_t in sys/procfs.h... yes
checking for dlopen in -ldl... yes
checking for the dynamic export flag... -Wl,--dynamic-list
checking for TD_VERSION... yes
checking whether the target supports __sync_*_compare_and_swap... yes
checking whether ADDR_NO_RANDOMIZE is declared... (cached) yes
configure: updating cache .././config.cache
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depdir commands
mkdir -p -- .deps
config.status: executing gdbdepdir commands
mkdir -p -- arch/.deps
mkdir -p -- common/.deps
make[1]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-i686/build'
make: *** [Makefile:850: all] Error 2
============================

Failures on Fedora-x86_64-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/9573>

Commit(s) tested:
	190852c8ac75cb62a737c58edfadfb0e1fcef78a

Author(s) (in the same order as the commits):
	Joel Brobecker <brobecker@adacore.com>

Subject:
	gdbserver/Windows: crash during connection establishment phase

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/19/190852c8ac75cb62a737c58edfadfb0e1fcef78a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail?id=6ab5eec>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table?id=6ab5eec>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/9618>

Commit(s) tested:
	190852c8ac75cb62a737c58edfadfb0e1fcef78a

Author(s) (in the same order as the commits):
	Joel Brobecker <brobecker@adacore.com>

Subject:
	gdbserver/Windows: crash during connection establishment phase

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/19/190852c8ac75cb62a737c58edfadfb0e1fcef78a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail?id=e410651>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table?id=e410651>

*** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE ***

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32/builds/1595>

Commit(s) tested:
	190852c8ac75cb62a737c58edfadfb0e1fcef78a

Author(s) (in the same order as the commits):
	Joel Brobecker <brobecker@adacore.com>

Subject:
	gdbserver/Windows: crash during connection establishment phase

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-w64-mingw32/19/190852c8ac75cb62a737c58edfadfb0e1fcef78a/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    s390-linux-tdep.o
  CXX    s390-tdep.o
  CXX    score-tdep.o
  CXX    sh-linux-tdep.o
  CXX    sh-nbsd-tdep.o
  CXX    sh-tdep.o
  CXX    sol2-tdep.o
  CXX    solib-aix.o
  CXX    solib-darwin.o
  CXX    solib-dsbt.o
  CXX    solib-frv.o
  CXX    solib-spu.o
  CXX    solib-svr4.o
  CXX    sparc-linux-tdep.o
  CXX    sparc-nbsd-tdep.o
  CXX    sparc-obsd-tdep.o
  CXX    sparc-ravenscar-thread.o
  CXX    sparc-sol2-tdep.o
  CXX    sparc-tdep.o
  CXX    spu-multiarch.o
  CXX    spu-tdep.o
  CXX    symfile-mem.o
  CXX    tic6x-linux-tdep.o
  CXX    tic6x-tdep.o
  CXX    tilegx-linux-tdep.o
  CXX    tilegx-tdep.o
  CXX    v850-tdep.o
  CXX    vax-nbsd-tdep.o
  CXX    vax-tdep.o
  CXX    windows-tdep.o
  CXX    x86-tdep.o
  CXX    xcoffread.o
  CXX    xstormy16-tdep.o
  CXX    xtensa-config.o
  CXX    xtensa-linux-tdep.o
  CXX    xtensa-tdep.o
  CXX    aarch64-fbsd-tdep.o
  CXX    aarch64-linux-tdep.o
  CXX    aarch64-newlib-tdep.o
  CXX    aarch64-tdep.o
  CXX    alpha-bsd-tdep.o
  CXX    alpha-linux-tdep.o
  CXX    alpha-mdebug-tdep.o
  CXX    alpha-nbsd-tdep.o
  CXX    alpha-obsd-tdep.o
  CXX    alpha-tdep.o
  CXX    amd64-darwin-tdep.o
  CXX    amd64-dicos-tdep.o
  CXX    amd64-fbsd-tdep.o
  CXX    amd64-linux-tdep.o
  CXX    amd64-nbsd-tdep.o
  CXX    amd64-obsd-tdep.o
  CXX    amd64-sol2-tdep.o
  CXX    amd64-tdep.o
  CXX    amd64-windows-tdep.o
  CXX    arch/aarch64.o
  CXX    arch/aarch64-insn.o
  CXX    arch/amd64.o
  CXX    ia64-linux-tdep.o
  CXX    ia64-tdep.o
  CXX    ia64-vms-tdep.o
  CXX    mips64-obsd-tdep.o
  CXX    sparc64-fbsd-tdep.o
  CXX    sparc64-linux-tdep.o
  CXX    sparc64-nbsd-tdep.o
  CXX    sparc64-obsd-tdep.o
  CXX    sparc64-sol2-tdep.o
  CXX    sparc64-tdep.o
  CXX    ser-base.o
  CXX    ser-tcp.o
  CXX    ser-mingw.o
  CXX    x86-nat.o
  CXX    x86-dregs.o
  CXX    windows-nat.o
  CXX    amd64-windows-nat.o
  CXX    cli/cli-cmds.o
  CXX    cli/cli-decode.o
  CXX    cli/cli-dump.o
  CXX    cli/cli-interp.o
  CXX    cli/cli-logging.o
../../binutils-gdb/gdb/windows-nat.c: In function 'handle_exception_result handle_exception(target_waitstatus*)':
../../binutils-gdb/gdb/windows-nat.c:1255:2: error: this statement may fall through [-Werror=implicit-fallthrough=]
  }
  ^
../../binutils-gdb/gdb/windows-nat.c:1257:5: note: here
     default:
     ^~~~~~~
  CXX    cli/cli-script.o
../../binutils-gdb/gdb/windows-nat.c: In member function 'virtual void windows_nat_target::create_inferior(const char*, const string&, char**, int)':
../../binutils-gdb/gdb/windows-nat.c:2795:26: warning: 'shell[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (useshell && shell[0] != '\0')
                   ~~~~~~~^
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:1610: windows-nat.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build/gdb'
make[1]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build'
make[1]: *** [Makefile:8800: all-gdb] Error 2
make: *** [Makefile:857: all] Error 2
============================

Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu-trusty-aarch32-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-AArch32-native-extended-gdbserver-m32/builds/3445>

Commit(s) tested:
	190852c8ac75cb62a737c58edfadfb0e1fcef78a

Author(s) (in the same order as the commits):
	Joel Brobecker <brobecker@adacore.com>

Subject:
	gdbserver/Windows: crash during connection establishment phase

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-AArch32-native-extended-gdbserver-m32/19/190852c8ac75cb62a737c58edfadfb0e1fcef78a/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=15: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=17: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=18: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.