public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Fix tcl error in gdb.mi/list-thread-groups-available.exp
@ 2020-03-14  4:33 gdb-buildbot
  2020-03-14  4:33 ` Failures on Fedora-i686, branch master gdb-buildbot
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: gdb-buildbot @ 2020-03-14  4:33 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1ef44e861d58ba10674f107a79471852fbd27cda ***

commit 1ef44e861d58ba10674f107a79471852fbd27cda
Author:     Tom de Vries <tdevries@suse.de>
AuthorDate: Tue Mar 3 10:50:07 2020 +0100
Commit:     Tom de Vries <tdevries@suse.de>
CommitDate: Tue Mar 3 10:50:07 2020 +0100

    [gdb/testsuite] Fix tcl error in gdb.mi/list-thread-groups-available.exp
    
    When running gdb.mi/list-thread-groups-available.exp, we get:
    ...
    Running gdb.mi/list-thread-groups-available.exp ...
    ERROR: tcl error sourcing gdb.mi/list-thread-groups-available.exp.
    ERROR: Too many arguments to gdb_test_multiple
    ...
    
    The problem is that the gdb_test_multiple call has as last argument a
    $mi_gdb_prompt, which is no longer supported syntax since 590003dc0e
    "[gdb/testsuite] Add -lbl option in gdb_test_multiple".
    
    Fix this by using the new -prompt syntax.
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2020-03-03  Tom de Vries  <tdevries@suse.de>
    
            * gdb.mi/list-thread-groups-available.exp: Use -prompt syntax for
            gdb_test_multiple call.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index c3e154dbae..73a05d3143 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-03  Tom de Vries  <tdevries@suse.de>
+
+	* gdb.mi/list-thread-groups-available.exp: Use -prompt syntax for
+	gdb_test_multiple call.
+
 2020-03-03  Tom de Vries  <tdevries@suse.de>
 
 	* gdb.mi/mi-sym-info.exp: Add missing -prompt "$mi_gdb_prompt$" to
diff --git a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
index 4cc7ce7b51..697ee343d8 100644
--- a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
+++ b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp
@@ -56,7 +56,9 @@ set process_entry_re "{${id_re},${type_re}(,$description_re)?(,$user_re)?(,$core
 
 # The list can be long, so read entries one by one to avoid hitting the
 # timeout (especially when running with check-read1).
-gdb_test_multiple "-list-thread-groups --available" "list available thread groups" {
+set cmd "-list-thread-groups --available"
+set test "list available thread groups"
+gdb_test_multiple $cmd $test -prompt "$mi_gdb_prompt" {
     -re "\\^done,groups=\\\[" {
 	# The beginning of the response.
 	exp_continue
@@ -71,7 +73,7 @@ gdb_test_multiple "-list-thread-groups --available" "list available thread group
 	# The last entry.
 	pass $gdb_test_name
     }
-} $mi_gdb_prompt
+}
 
 # List specific processes, make sure there are two entries.
 set spawn_id_1 [remote_spawn target $binfile]


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-03-16 21:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-14  4:33 [binutils-gdb] [gdb/testsuite] Fix tcl error in gdb.mi/list-thread-groups-available.exp gdb-buildbot
2020-03-14  4:33 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-03-14  5:02 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-03-14  5:40 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-03-14  5:45 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-03-14  6:26 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-15 19:52 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-15 21:41 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2020-03-15 23:52 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-03-16 21:42 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).