public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove NO_DATA_STRING
@ 2019-08-30 19:52 gdb-buildbot
  2019-08-30 20:11 ` Failures on Debian-s390x-native-extended-gdbserver-m64, branch master gdb-buildbot
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: gdb-buildbot @ 2019-08-30 19:52 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 1f6d2f100ae6de462f1e81b5de17de059f6b17ef ***

commit 1f6d2f100ae6de462f1e81b5de17de059f6b17ef
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Sun Jul 14 08:21:16 2019 -0600
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Fri Aug 30 12:57:02 2019 -0600

    Remove NO_DATA_STRING
    
    NO_DATA_STRING shouldn't be used.  It's referenced in a single spot,
    in tui_data_window::display_all_data.  This patch removes the use and
    replaces it with the more correct text.  A later patch (though not in
    this series) will remove this call entirely, when it's more obviously
    correct to do so.
    
    gdb/ChangeLog
    2019-08-30  Tom Tromey  <tom@tromey.com>
    
            * tui/tui-regs.c (tui_data_window::display_all_data): Change
            text.
            * tui/tui-data.h (NO_DATA_STRING): Remove define.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fba2f4a995..0cb864fdfc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-08-30  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui-regs.c (tui_data_window::display_all_data): Change
+	text.
+	* tui/tui-data.h (NO_DATA_STRING): Remove define.
+
 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 	    Sergio Durigan Junior  <sergiodj@redhat.com>
 
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index f43035674d..1810fa3e72 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -98,7 +98,6 @@ public:
 
 /* Constant definitions.  */
 #define DEFAULT_TAB_LEN         8
-#define NO_DATA_STRING          "[ No Data Values Displayed ]"
 #define SRC_NAME                "src"
 #define CMD_NAME                "cmd"
 #define DATA_NAME               "regs"
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 71037d4104..24b182f2ae 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -437,7 +437,7 @@ void
 tui_data_window::display_all_data ()
 {
   if (regs_content.empty ())
-    erase_data_content (NO_DATA_STRING);
+    erase_data_content (_("[ Register Values Unavailable ]"));
   else
     {
       erase_data_content (NULL);


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-08-30 20:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 19:52 [binutils-gdb] Remove NO_DATA_STRING gdb-buildbot
2019-08-30 20:11 ` Failures on Debian-s390x-native-extended-gdbserver-m64, branch master gdb-buildbot
2019-08-30 20:14 ` Failures on Fedora-i686, " gdb-buildbot
2019-08-30 20:22 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2019-08-30 20:27 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-08-30 20:28 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-08-30 20:28 ` Failures on Debian-s390x-m64, " gdb-buildbot
2019-08-30 20:28 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-08-30 20:28 ` Failures on Debian-s390x-native-gdbserver-m64, " gdb-buildbot
2019-08-30 20:52 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).