public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] PowerPC64 GOT reloc reserving PLT entry for ifunc
Date: Fri, 01 May 2020 01:17:16 -0400	[thread overview]
Message-ID: <2165dc8d90ef9618a1db9bc596f433b02b7cc54a@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 2165dc8d90ef9618a1db9bc596f433b02b7cc54a ***

commit 2165dc8d90ef9618a1db9bc596f433b02b7cc54a
Author:     Alan Modra <amodra@gmail.com>
AuthorDate: Thu Apr 16 12:45:30 2020 +0930
Commit:     Alan Modra <amodra@gmail.com>
CommitDate: Thu Apr 16 15:43:19 2020 +0930

    PowerPC64 GOT reloc reserving PLT entry for ifunc
    
    I can't see any reason why ELFv2 should create a PLT entry for ifuncs
    referenced by GOT relocs as long as the GOT entry remains.  The GOT
    entry ought to be resolved by ld.so to the value returned by the ifunc
    resolver, or if there is global entry stub created for some other
    reason, by the linker to the stub address.
    
            * elf64-ppc.c (ppc64_elf_check_relocs): Don't create plt entries
            for GOT relocs against ifuncs.

diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 25a3e468a7..63de3aba59 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -4774,14 +4774,6 @@ ppc64_elf_check_relocs (bfd *abfd, struct bfd_link_info *info,
 	    if (!update_local_sym_info (abfd, symtab_hdr, r_symndx,
 					rel->r_addend, tls_type))
 	      return FALSE;
-
-	  /* We may also need a plt entry if the symbol turns out to be
-	     an ifunc.  */
-	  if (h != NULL && !bfd_link_pic (info) && abiversion (abfd) != 1)
-	    {
-	      if (!update_plt_info (abfd, &h->plt.plist, rel->r_addend))
-		return FALSE;
-	    }
 	  break;
 
 	case R_PPC64_PLT16_HA:


             reply	other threads:[~2020-05-01  5:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01  5:17 gdb-buildbot [this message]
2020-05-01  5:17 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-05-01  5:39 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-05-01  6:14 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-05-01  6:25 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-05-01  6:56 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-05-01 17:24 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-05-02 19:36 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-05-06  5:33 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2165dc8d90ef9618a1db9bc596f433b02b7cc54a@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).