[binutils-gdb] Re: Memory leak in dwarf2.c

[binutils-gdb] Re: Memory leak in dwarf2.c

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 217d2eaa69c2a5d58cdfd11619c4f2e41c986826 ***

commit 217d2eaa69c2a5d58cdfd11619c4f2e41c986826
Author:     Alan Modra <amodra@gmail.com>
AuthorDate: Mon Sep 2 16:48:44 2019 +0930
Commit:     Alan Modra <amodra@gmail.com>
CommitDate: Mon Sep 2 16:50:22 2019 +0930

    Re: Memory leak in dwarf2.c
    
            PR 11983
            * dwarf2.c (read_alt_indirect_string): Free debug_filename
            on success.  Tidy.
            (read_alt_indirect_ref): Likewise.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 47f694ad75..f033af7443 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -3,6 +3,8 @@
 	PR 11983
 	* dwarf2.c (_bfd_dwarf2_slurp_debug_info): Free debug_filename
 	on success.  Tidy.
+	(read_alt_indirect_string): Likewise.
+	(read_alt_indirect_ref): Likewise.
 
 2019-08-31  Jim Wilson  <jimw@sifive.com>
 
diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
index 88638b903f..ed6dcd48c7 100644
--- a/bfd/dwarf2.c
+++ b/bfd/dwarf2.c
@@ -802,20 +802,21 @@ read_alt_indirect_string (struct comp_unit * unit,
 
   if (stash->alt_bfd_ptr == NULL)
     {
-      bfd *  debug_bfd;
-      char * debug_filename = bfd_follow_gnu_debugaltlink (unit->abfd, DEBUGDIR);
+      bfd *debug_bfd;
+      char *debug_filename = bfd_follow_gnu_debugaltlink (unit->abfd, DEBUGDIR);
 
       if (debug_filename == NULL)
 	return NULL;
 
-      if ((debug_bfd = bfd_openr (debug_filename, NULL)) == NULL
-	  || ! bfd_check_format (debug_bfd, bfd_object))
-	{
-	  if (debug_bfd)
-	    bfd_close (debug_bfd);
+      debug_bfd = bfd_openr (debug_filename, NULL);
+      free (debug_filename);
+      if (debug_bfd == NULL)
+	/* FIXME: Should we report our failure to follow the debuglink ?  */
+	return NULL;
 
-	  /* FIXME: Should we report our failure to follow the debuglink ?  */
-	  free (debug_filename);
+      if (!bfd_check_format (debug_bfd, bfd_object))
+	{
+	  bfd_close (debug_bfd);
 	  return NULL;
 	}
       stash->alt_bfd_ptr = debug_bfd;
@@ -850,20 +851,21 @@ read_alt_indirect_ref (struct comp_unit * unit,
 
   if (stash->alt_bfd_ptr == NULL)
     {
-      bfd *  debug_bfd;
-      char * debug_filename = bfd_follow_gnu_debugaltlink (unit->abfd, DEBUGDIR);
+      bfd *debug_bfd;
+      char *debug_filename = bfd_follow_gnu_debugaltlink (unit->abfd, DEBUGDIR);
 
       if (debug_filename == NULL)
 	return FALSE;
 
-      if ((debug_bfd = bfd_openr (debug_filename, NULL)) == NULL
-	  || ! bfd_check_format (debug_bfd, bfd_object))
-	{
-	  if (debug_bfd)
-	    bfd_close (debug_bfd);
+      debug_bfd = bfd_openr (debug_filename, NULL);
+      free (debug_filename);
+      if (debug_bfd == NULL)
+	/* FIXME: Should we report our failure to follow the debuglink ?  */
+	return NULL;
 
-	  /* FIXME: Should we report our failure to follow the debuglink ?  */
-	  free (debug_filename);
+      if (!bfd_check_format (debug_bfd, bfd_object))
+	{
+	  bfd_close (debug_bfd);
 	  return NULL;
 	}
       stash->alt_bfd_ptr = debug_bfd;

Failures on Ubuntu-Aarch64-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/8/builds/644

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Debian-s390x-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Debian-s390x-native-extended-gdbserver-m64

Worker:
        debian-jessie-s390x-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/12/builds/93

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Debian-s390x-native-extended-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=14: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=5: wait for stops
PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: other threads ran - unlocked
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Debian-s390x-native-extended-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Debian-s390x-native-extended-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Debian-s390x-m64, branch master

[gdb-buildbot]

Buildername:
        Debian-s390x-m64

Worker:
        debian-jessie-s390x-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/25/builds/89

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Debian-s390x-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=0: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=11: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=12: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=13: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=14: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=15: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=3: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=7: wait for stops
PASS -> UNRESOLVED: gdb.tui/empty.exp: asm-regs: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: asm: 90x40: box 1
PASS -> UNRESOLVED: gdb.tui/empty.exp: split-regs: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 90x40: box 1
PASS -> FAIL: gdb.tui/empty.exp: split: 90x40: box 1
PASS -> UNRESOLVED: gdb.tui/empty.exp: src-regs: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 90x40: box 1
PASS -> FAIL: gdb.tui/empty.exp: src: 90x40: box 1
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Debian-s390x-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Debian-s390x-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/744

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/721

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: no new threads
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: set breakpoint always-inserted on
PASS -> FAIL: gdb.threads/continue-pending-status.exp: attempt 12: caught interrupt
PASS -> FAIL: gdb.threads/continue-pending-status.exp: attempt 13: set break in tight loop
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Debian-s390x-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Debian-s390x-native-gdbserver-m64

Worker:
        debian-jessie-s390x-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/21/builds/69

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Debian-s390x-native-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=11: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=14: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=2: wait for stops
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Debian-s390x-native-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Debian-s390x-native-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/722

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/720

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/717

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/718

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/717

Author:
        Alan Modra <amodra@gmail.com>

Commit tested:
        217d2eaa69c2a5d58cdfd11619c4f2e41c986826

Subject of commit:
        Re: Memory leak in dwarf2.c

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/21/217d2eaa69c2a5d58cdfd11619c4f2e41c986826//xfail.table.gz>